lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202504071330.90FC6D8@keescook>
Date: Mon, 7 Apr 2025 13:30:46 -0700
From: Kees Cook <kees@...nel.org>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: James Smart <james.smart@...adcom.com>,
	Ram Vegesna <ram.vegesna@...adcom.com>,
	"James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	linux-hardening@...r.kernel.org, linux-scsi@...r.kernel.org,
	target-devel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: elx: sli4: Replace deprecated strncpy() with
 strscpy()

On Mon, Apr 07, 2025 at 09:01:53PM +0200, Thorsten Blum wrote:
> On 7. Apr 2025, at 20:28, Kees Cook wrote:
> > On Wed, Feb 26, 2025 at 07:55:26PM +0100, Thorsten Blum wrote:
> >> strncpy() is deprecated for NUL-terminated destination buffers; use
> >> strscpy() instead.
> >> 
> >> Compile-tested only.
> >> 
> >> Link: https://github.com/KSPP/linux/issues/90
> >> Cc: linux-hardening@...r.kernel.org
> >> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> >> ---
> > 
> > Standard question for these kinds of conversions: Why is it safe that
> > this is not NUL padded? I haven't found where this buffer is being
> > zeroed out, but it probably is (given the "- 1" on the length), but
> > without run-time testing, this needs much more careful analysis.
> 
> I think this was submitted before I started to explain this better.
> 
> 'wr_obj' is the zeroed out 'buf' returned from sli_config_cmd_init().

I don't see how dma->virt and buf are associated?

> 
> I'll update the description and submit a v2.

Thanks!

> 
> Thanks,
> Thorsten
> 

-- 
Kees Cook

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ