[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <7f16ef040821818a0ac8f35b5636877eb7041bd8.camel@sipsolutions.net>
Date: Mon, 07 Apr 2025 22:34:27 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Kees Cook <kees@...nel.org>, "Gustavo A. R. Silva"
<gustavoars@...nel.org>
Cc: Miri Korenblit <miriam.rachel.korenblit@...el.com>,
linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-hardening@...r.kernel.org
Subject: Re: [PATCH][next] wifi: iwlwifi: mvm: d3: Avoid
-Wflex-array-member-not-at-end warnings
On Mon, 2025-04-07 at 13:15 -0700, Kees Cook wrote:
> lots of quotes
It'd be really good if you could trim the quotes a bit ...
> > + wkc->mac_id_n_color =
> > + cpu_to_le32(FW_CMD_ID_AND_COLOR(mvmvif->id,
> > + mvmvif->color));
> > + wkc->num_keys = 1;
>
> Looks like struct iwl_mvm_wep_key_cmd::num_keys is the counted_by for
> struct iwl_mvm_wep_key_cmd::wep_key?
No no no. I'm still burned by you adding this to various places
elsewhere in the wireless stack, let's not.
Btw, Gustavo, I think it was probably the other iwlwifi patch, but
please also make sure kernel-doc doesn't start complaining, we are
trying keep it that way.
johannes
Powered by blists - more mailing lists