linux-kernel - Re: [PATCH] cxl : fix cxlctl_validate_hw_command() warn: always true condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <deb343df-39be-4bf9-9288-179a73154ad0@zohomail.com>
Date: Mon, 7 Apr 2025 14:10:20 +0800
From: Li Ming <ming.li@...omail.com>
To: xiaopeitux@...mail.com, Pei Xiao <xiaopei01@...inos.cn>
Cc: dave@...olabs.net, jonathan.cameron@...wei.com, dave.jiang@...el.com,
 alison.schofield@...el.com, vishal.l.verma@...el.com, ira.weiny@...el.com,
 dan.j.williams@...el.com, linux-cxl@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cxl : fix cxlctl_validate_hw_command() warn: always true
 condition

On 4/7/2025 11:41 AM, xiaopeitux@...mail.com wrote:
> From: Pei Xiao <xiaopei01@...inos.cn>
>
> smatch warnings:
>     drivers/cxl/core/features.c:441 cxlctl_validate_hw_command()
>     warn: always true condition '(scope >= 0) => (0-u32max >= 0)'
>
> remove always true condition.
>
> Signed-off-by: Pei Xiao <xiaopei01@...inos.cn>
> ---
>  drivers/cxl/core/features.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/cxl/core/features.c b/drivers/cxl/core/features.c
> index f4daefe3180e..fdca93c984ce 100644
> --- a/drivers/cxl/core/features.c
> +++ b/drivers/cxl/core/features.c
> @@ -616,9 +616,8 @@ static bool cxlctl_validate_hw_command(struct cxl_features_state *cxlfs,
>  	case CXL_MBOX_OP_GET_FEATURE:
>  		if (cxl_mbox->feat_cap < CXL_FEATURES_RO)
>  			return false;
> -		if (scope >= FWCTL_RPC_CONFIGURATION)
> +		else
>  			return true;
> -		return false;
>  	case CXL_MBOX_OP_SET_FEATURE:
>  		if (cxl_mbox->feat_cap < CXL_FEATURES_RW)
>  			return false;

Already have a patch posted for this issue.

https://lore.kernel.org/linux-cxl/67f02de69d89c_9fe8529481@iweiny-mobl.notmuch/T/#m84c3093032b5eb167bbb1d0a787019d0387f4ae8