linux-kernel - Re: [PATCH net-next v6] net: dlink: add support for reporting stats via `ethtool -S` and `ip -s -s link show`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86ac7c66-66da-458f-960a-3b27ba5e893f@lunn.ch>
Date: Mon, 7 Apr 2025 22:48:01 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Moon Yeounsu <yyyynoom@...il.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v6] net: dlink: add support for reporting stats
 via `ethtool -S` and `ip -s -s link show`


> Additionally, the previous code did not manage statistics
> in a structured manner, so this patch:
> 
> 1. Added `u64` type stat counters to the `netdev_private` struct.
> 2. Defined a `dlink_stats` struct for managing statistics.
> 3. Registered standard statistics and driver-specific statistics
> separately.
> 4. Compressing repetitive tasks through loops.
> 
> The code previously blocked by the `#ifdef MEM_MAPPING` preprocessor
> directive has been enabled. This section relates to RMON statistics and
> does not cause issues when activated. Removing unnecessary preprocessor
> directives simplifies the code path and makes it more intuitive.

When i see a list like this, it makes me think this should be broken
up into multiple patches. Ideally you want lots of simple patches
which are obviously correct.

	Andrew