linux-kernel - Re: [PATCH v3 1/2] dt-bindings: mailbox: Add support for bcm74110

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9088acd0-4650-4b10-88f9-6b6c0b1f9978@broadcom.com>
Date: Mon, 7 Apr 2025 13:57:42 -0700
From: Justin Chen <justin.chen@...adcom.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: florian.fainelli@...adcom.com, conor+dt@...nel.org, krzk+dt@...nel.org,
 robh@...nel.org, jassisinghbrar@...il.com,
 bcm-kernel-feedback-list@...adcom.com
Subject: Re: [PATCH v3 1/2] dt-bindings: mailbox: Add support for bcm74110


On 4/6/25 5:27 AM, Krzysztof Kozlowski wrote:
> On 05/04/2025 00:20, justin.chen@...adcom.com wrote:
>> +
>> +maintainers:
>> +  - Justin Chen <justin.chen@...adcom.com>
>> +  - Florian Fainelli <florian.fainelli@...adcom.com>
>> +
>> +description: Broadcom mailbox hardware first introduced with 74110
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - brcm,bcm74110-mbox
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  interrupts:
>> +    minItems: 1
> 
> Third version of patchset, third entirely different code.
> 
> Decide finally what is the hardware and send binding matching it.
> Hardware did not change last one week three times.
> 
> Drop minItems or explain why this is flexible on the same SoC or between
> boards using same SoC. You can always point me to upstream DTS, which
> would solve many questions.
> 

We do not have an upstream DTS. We have a scripting engine that 
generates a DTS and we distribute DTBs to our customers. The example 
from v2 of my patch was copied from said generated DTS.

Apologies as I navigate through the different yaml keywords here. The HW
isn't changing, I am just struggling with representing the HW using the
different keywords. And the different implications of using said keywords.

Here is what I have for v4.
      items:
        - description: RX doorbell and watermark interrupts
        - description: TX doorbell and watermark interrupts
+    description:
+      RX interrupts are required to notify the host of pending messages. TX
+      interrupts are optional. The TX doorbell interrupt is not used by the
+      host, but watermark interrupts may be used to notify a host 
waiting on
+      a full out queue.

Thanks,
Justin

>> +    items:
>> +      - description: RX doorbell and watermark interrupts
>> +      - description: TX doorbell and watermark interrupts
>> +
> 
> 
> Best regards,
> Krzysztof