linux-kernel - Re: [RESEND PATCH v2] hwmon: (max6639) : Allow setting target RPM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54c57f1c-38f4-42ad-9aca-05233c9a4483@roeck-us.net>
Date: Mon, 7 Apr 2025 15:52:17 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Your Name <naresh.solanki@...ements.com>
Cc: Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH v2] hwmon: (max6639) : Allow setting target RPM

On Fri, Apr 04, 2025 at 05:26:45PM +0530, Your Name wrote:
> From: Naresh Solanki <naresh.solanki@...ements.com>
> 
> Currently, during startup, the fan is set to its maximum RPM by default,
> which may not be suitable for all use cases.
> This patch introduces support for specifying a target RPM via the Device
> Tree property "target-rpm".
> 
> Changes:
> - Added `target_rpm` field to `max6639_data` structure to store the
>   target RPM for each fan channel.
> - Modified `max6639_probe_child_from_dt()` to read the `"target-rpm"`
>   property from the Device Tree and set `target_rpm` accordingly.
> - Updated `max6639_init_client()` to use `target_rpm` to compute the
>   initial PWM duty cycle instead of defaulting to full speed (120/120).
> 
> Behavior:
> - If `"target-rpm"` is specified, the fan speed is set accordingly.
> - If `"target-rpm"` is not specified, the previous behavior (full speed
>   at startup) is retained.
> 
> This allows better control over fan speed during system initialization.
> 
> Signed-off-by: Naresh Solanki <naresh.solanki@...ements.com>

Applied.

Thanks,
Guenter