linux-kernel - Re: [PATCH 6/9] dt-bindings: mmc: sdhci-of-dwcmhsc: Add Sophgo SG2044 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7wklz2qbo3pej7plhdwcuwilbkntfiyuadjpihuhedkvhgvz6p@3h2hxhw54lgq>
Date: Tue, 8 Apr 2025 07:32:14 +0800
From: Inochi Amaoto <inochiama@...il.com>
To: Rob Herring <robh@...nel.org>, Inochi Amaoto <inochiama@...il.com>
Cc: Jean Delvare <jdelvare@...e.com>, Guenter Roeck <linux@...ck-us.net>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Chen Wang <unicorn_wang@...look.com>, Andi Shyti <andi.shyti@...nel.org>, 
	Thomas Gleixner <tglx@...utronix.de>, Paul Walmsley <paul.walmsley@...ive.com>, 
	Samuel Holland <samuel.holland@...ive.com>, Ulf Hansson <ulf.hansson@...aro.org>, 
	Philipp Zabel <p.zabel@...gutronix.de>, Palmer Dabbelt <palmer@...belt.com>, 
	Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>, 
	Daniel Lezcano <daniel.lezcano@...aro.org>, Thomas Bonnefille <thomas.bonnefille@...tlin.com>, 
	ghost <2990955050@...com>, Jarkko Nikula <jarkko.nikula@...ux.intel.com>, 
	Jisheng Zhang <jszhang@...nel.org>, Chao Wei <chao.wei@...hgo.com>, linux-hwmon@...r.kernel.org, 
	devicetree@...r.kernel.org, sophgo@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	linux-i2c@...r.kernel.org, linux-riscv@...ts.infradead.org, linux-mmc@...r.kernel.org, 
	Yixun Lan <dlan@...too.org>, Longbin Li <looong.bin@...il.com>
Subject: Re: [PATCH 6/9] dt-bindings: mmc: sdhci-of-dwcmhsc: Add Sophgo
 SG2044 support

On Mon, Apr 07, 2025 at 09:00:15AM -0500, Rob Herring wrote:
> On Mon, Apr 07, 2025 at 09:06:11AM +0800, Inochi Amaoto wrote:
> > The sdhci IP of SG2044 is similar to it of SG2042. They
> > share the same clock and controller configuration.
> > 
> > Add compatible string for SG2044.
> > 
> > Signed-off-by: Inochi Amaoto <inochiama@...il.com>
> > ---
> >  .../devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml        | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> > index e6e604072d3c..47b5fc1b8e07 100644
> > --- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> > @@ -19,6 +19,9 @@ properties:
> >                - rockchip,rk3562-dwcmshc
> >                - rockchip,rk3576-dwcmshc
> >            - const: rockchip,rk3588-dwcmshc
> > +      - items:
> > +          - const: sophgo,sg2044-dwcmshc
> > +          - const: sophgo,sg2042-dwcmshc
> >        - enum:
> >            - rockchip,rk3568-dwcmshc
> >            - rockchip,rk3588-dwcmshc
> > @@ -74,7 +77,9 @@ allOf:
> >        properties:
> >          compatible:
> >            contains:
> > -            const: sophgo,sg2042-dwcmshc
> > +            enum:
> > +              - sophgo,sg2042-dwcmshc
> > +              - sophgo,sg2044-dwcmshc
> 
> No need for this hunk because the new one has sophgo,sg2042-dwcmshc 
> already.
> 
> Rob

Thanks, I will remove it.

Regards,
Inochi