linux-kernel - Re: [PATCH v4 1/2] mm/memblock: Add reserved memory release function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250407104032.162f1d10e9ab885c72bfac8c@kernel.org>
Date: Mon, 7 Apr 2025 10:40:32 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Masami Hiramatsu (Google) <mhiramat@...nel.org>
Cc: Wei Yang <richard.weiyang@...il.com>, Steven Rostedt
 <rostedt@...dmis.org>, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org, Mark Rutland <mark.rutland@....com>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, Andrew Morton
 <akpm@...ux-foundation.org>, Mike Rapoport <rppt@...nel.org>,
 linux-mm@...ck.org
Subject: Re: [PATCH v4 1/2] mm/memblock: Add reserved memory release
 function

On Mon, 7 Apr 2025 09:33:51 +0900
Masami Hiramatsu (Google) <mhiramat@...nel.org> wrote:

> But this is fragile by design. As I did for lib/bootconfig and
> tools/bootconfig, you should use __KERNEL__ and makes it not depending on
> the kernel header files because it does not expected to be used in user
> space.
> Even if I added mutex.h, it stopped with another reason.
> 
> test -L linux/memblock.h || ln -s ../../../../include/linux/memblock.h linux/memblock.h
> test -L asm/asm.h || ln -s ../../../arch/x86/include/asm/asm.h asm/asm.h
> test -L asm/cmpxchg.h || ln -s ../../../arch/x86/include/asm/cmpxchg.h asm/cmpxchg.h
> cc -I. -I../../include -Wall -O2 -fsanitize=address -fsanitize=undefined -D CONFIG_PHYS_ADDR_T_64BIT   -c -o main.o main.c
> test -L memblock.c || ln -s ../../../mm/memblock.c memblock.c
> cc -I. -I../../include -Wall -O2 -fsanitize=address -fsanitize=undefined -D CONFIG_PHYS_ADDR_T_64BIT   -c -o memblock.o memblock.c
> memblock.c: In function 'memblock_add_range.isra':
> memblock.c:685:17: warning: 'end_rgn' may be used uninitialized [-Wmaybe-uninitialized]
>   685 |                 memblock_merge_regions(type, start_rgn, end_rgn);
>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> memblock.c:591:42: note: 'end_rgn' was declared here
>   591 |         int idx, nr_new, start_rgn = -1, end_rgn;
>       |                                          ^~~~~~~
> cc -I. -I../../include -Wall -O2 -fsanitize=address -fsanitize=undefined -D CONFIG_PHYS_ADDR_T_64BIT   -c -o lib/slab.o lib/slab.c
> cc -I. -I../../include -Wall -O2 -fsanitize=address -fsanitize=undefined -D CONFIG_PHYS_ADDR_T_64BIT   -c -o mmzone.o mmzone.c
> cc -I. -I../../include -Wall -O2 -fsanitize=address -fsanitize=undefined -D CONFIG_PHYS_ADDR_T_64BIT   -c -o slab.o ../../lib/slab.c
> ../../lib/slab.c:6:10: fatal error: urcu/uatomic.h: No such file or directory
>     6 | #include <urcu/uatomic.h>
>       |          ^~~~~~~~~~~~~~~~
> compilation terminated.
> make: *** [<builtin>: slab.o] Error 1

Ah, sorry. This is from liburcu. I installed the package and fixes the issue.
Let me send the patch.

Thank you,

-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>