linux-kernel - Re: [PATCH] spi: spi-qpic: fix common module build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <875xjgflkf.fsf@bootlin.com>
Date: Mon, 07 Apr 2025 10:00:16 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Richard Weinberger <richard@....at>,  Vignesh Raghavendra
 <vigneshr@...com>,  Md Sadre Alam <quic_mdalam@...cinc.com>,  Mark Brown
 <broonie@...nel.org>,  Varadarajan Narayanan <quic_varada@...cinc.com>,
  Sricharan Ramabadhran <quic_srichara@...cinc.com>,  Arnd Bergmann
 <arnd@...db.de>,  linux-mtd@...ts.infradead.org,
  linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: spi-qpic: fix common module build

Hi Arnd,

On 07/04/2025 at 09:27:14 +02, Arnd Bergmann <arnd@...nel.org> wrote:

> From: Arnd Bergmann <arnd@...db.de>
>
> When the NAND driver is a loadable module, and the SPI driver is
> turned off, the common part is not built:
>
> ERROR: modpost: "qcom_nandc_unalloc" [drivers/spi/spi-qpic-snand.ko] undefined!
> ERROR: modpost: "qcom_write_reg_dma" [drivers/spi/spi-qpic-snand.ko] undefined!
> ERROR: modpost: "qcom_read_reg_dma" [drivers/spi/spi-qpic-snand.ko] undefined!
> ERROR: modpost: "qcom_nandc_dev_to_mem" [drivers/spi/spi-qpic-snand.ko] undefined!
> ERROR: modpost: "qcom_nandc_alloc" [drivers/spi/spi-qpic-snand.ko] undefined!
> ERROR: modpost: "qcom_submit_descs" [drivers/spi/spi-qpic-snand.ko] undefined!
> ERROR: modpost: "qcom_clear_read_regs" [drivers/spi/spi-qpic-snand.ko] undefined!
> ERROR: modpost: "qcom_clear_bam_transaction" [drivers/spi/spi-qpic-snand.ko] undefined!
> ERROR: modpost: "qcom_read_data_dma" [drivers/spi/spi-qpic-snand.ko] undefined!
> ERROR: modpost: "qcom_write_data_dma" [drivers/spi/spi-qpic-snand.ko] undefined!
>
> Simplify the Makefile to just build the common bits for either of the two,
> so it will be built-in whenever one of them is, or otherwise a loadable
> module if needed.
>
> Fixes: 7304d1909080 ("spi: spi-qpic: add driver for QCOM SPI NAND flash Interface")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks for the fix, I just applied Geert's identical patch this morning,
I was waiting for -rc1 to synchronize everything again:
https://lore.kernel.org/linux-mtd/174401012746.998658.11206994348683987630.b4-ty@bootlin.com/T/#t

Sorry for the delay.

Thanks,
Miquèl