linux-kernel - Re: [PATCH] media: qcom: camss: vfe: suppress VFE version log spam

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c0c3f814-552a-434a-9893-61d83b5a346b@linaro.org>
Date: Mon, 7 Apr 2025 09:18:15 +0100
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: Johan Hovold <johan+linaro@...nel.org>, Robert Foss <rfoss@...nel.org>,
 Todor Tomov <todor.too@...il.com>, Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: Hans Verkuil <hverkuil@...all.nl>, linux-media@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
 Depeng Shao <quic_depengs@...cinc.com>
Subject: Re: [PATCH] media: qcom: camss: vfe: suppress VFE version log spam

On 07/04/2025 08:31, Johan Hovold wrote:
> A recent commit refactored the printing of the VFE hardware version, but
> (without it being mentioned) also changed the log level from debug to
> info.
> 
> This results in several hundred lines of repeated log spam during boot
> and use, for example, on the Lenovo ThinkPad X13s:
> 
> 	qcom-camss ac5a000.camss: VFE:1 HW Version = 1.2.2
> 	qcom-camss ac5a000.camss: VFE:0 HW Version = 1.2.2
> 	qcom-camss ac5a000.camss: VFE:2 HW Version = 1.2.2
> 	qcom-camss ac5a000.camss: VFE:2 HW Version = 1.2.2
> 	qcom-camss ac5a000.camss: VFE:3 HW Version = 1.2.2
> 	qcom-camss ac5a000.camss: VFE:5 HW Version = 1.3.0
> 	qcom-camss ac5a000.camss: VFE:6 HW Version = 1.3.0
> 	qcom-camss ac5a000.camss: VFE:4 HW Version = 1.3.0
> 	qcom-camss ac5a000.camss: VFE:5 HW Version = 1.3.0
> 	qcom-camss ac5a000.camss: VFE:6 HW Version = 1.3.0
> 	qcom-camss ac5a000.camss: VFE:7 HW Version = 1.3.0
> 	qcom-camss ac5a000.camss: VFE:7 HW Version = 1.3.0
> 	qcom-camss ac5a000.camss: VFE:7 HW Version = 1.3.0
> 	...
> 
> Suppress the version logging by demoting to debug level again.
> 
> Cc: Depeng Shao <quic_depengs@...cinc.com>
> Fixes: 10693fed125d ("media: qcom: camss: vfe: Move common code into vfe core")
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> ---
>   drivers/media/platform/qcom/camss/camss-vfe.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c
> index cf0e8f5c004a..1ed2518c7a6b 100644
> --- a/drivers/media/platform/qcom/camss/camss-vfe.c
> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c
> @@ -428,7 +428,7 @@ u32 vfe_hw_version(struct vfe_device *vfe)
>   	u32 rev = (hw_version >> HW_VERSION_REVISION) & 0xFFF;
>   	u32 step = (hw_version >> HW_VERSION_STEPPING) & 0xFFFF;
>   
> -	dev_info(vfe->camss->dev, "VFE:%d HW Version = %u.%u.%u\n",
> +	dev_dbg(vfe->camss->dev, "VFE:%d HW Version = %u.%u.%u\n",
>   		 vfe->id, gen, rev, step);
>   
>   	return hw_version;

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>