linux-kernel - Re: [GIT PULL] vfs mount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_OSEJ-Bd-wL1CpS@infradead.org>
Date: Mon, 7 Apr 2025 01:51:28 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Christoph Hellwig <hch@...radead.org>,
	Mateusz Guzik <mjguzik@...il.com>,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	Christian Brauner <brauner@...nel.org>,
	Leon Romanovsky <leon@...nel.org>, pr-tracker-bot@...nel.org,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] vfs mount

On Fri, Apr 04, 2025 at 07:19:27AM -0700, Linus Torvalds wrote:
> On Fri, 4 Apr 2025 at 01:28, Christoph Hellwig <hch@...radead.org> wrote:
> >
> > Or just kill the non-scoped guard because it simply is an insane API.
> 
> The scoped guard may be odd, but it's actually rather a common
> situation.  And when used with the proper indentation, it also ends up
> being pretty visually clear about what part of a function is under the
> lock.

The scoped one with proper indentation is fine.  The non-scoped one is
the one that is really confusing and odd.