linux-kernel - Re: [PATCH 11/12] gpio: ich: enable building with COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_OSqBgZpJpONuVn@smile.fi.intel.com>
Date: Mon, 7 Apr 2025 11:54:00 +0300
From: Andy Shevchenko <andy@...nel.org>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Linus Walleij <linus.walleij@...aro.org>,
	Orson Zhai <orsonzhai@...il.com>,
	Baolin Wang <baolin.wang@...ux.alibaba.com>,
	Chunyan Zhang <zhang.lyra@...il.com>,
	Peter Tyser <ptyser@...-inc.com>, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 11/12] gpio: ich: enable building with COMPILE_TEST=y

On Mon, Apr 07, 2025 at 09:13:20AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> Extend the build coverage by allowing to build the module with
> COMPILE_TEST enabled.

...

>  config GPIO_ICH
>  	tristate "Intel ICH GPIO"
> -	depends on X86
> -	depends on LPC_ICH
> +	depends on (X86 && LPC_ICH) || COMPILE_TEST

I don't see why LPC_ICH should be here.
We do all-or-none approach for compile test for (x86) MFD drivers,
no need to test it separately (it makes a little sense).

	depends on X86 || COMPILE_TEST
	depends on LPC_ICH

-- 
With Best Regards,
Andy Shevchenko