linux-kernel - Re: [PATCH v8] ufs: core: Add WB buffer resize support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250407085601.223-1-tanghuan@vivo.com>
Date: Mon,  7 Apr 2025 16:56:01 +0800
From: Huan Tang <tanghuan@...o.com>
To: huobean@...il.com
Cc: James.Bottomley@...senPartnership.com,
	alim.akhtar@...sung.com,
	avri.altman@....com,
	beanhuo@...ron.com,
	bvanassche@....org,
	ebiggers@...gle.com,
	keosung.park@...sung.com,
	linux-kernel@...r.kernel.org,
	linux-scsi@...r.kernel.org,
	linux@...ssschuh.net,
	luhongfei@...o.com,
	manivannan.sadhasivam@...aro.org,
	martin.petersen@...cle.com,
	minwoo.im@...sung.com,
	opensource.kernel@...o.com,
	peter.wang@...iatek.com,
	quic_cang@...cinc.com,
	quic_mnaresh@...cinc.com,
	quic_nguyenb@...cinc.com,
	tanghuan@...o.com,
	viro@...iv.linux.org.uk
Subject: Re: [PATCH v8] ufs: core: Add WB buffer resize support

> you must ensure the mode en_mode is within valid range (0-2), why not
> use enum?
> 
> 
> > +{
> > +       int ret;
> > +       u8 index;
> > +
> > +       index = ufshcd_wb_get_query_index(hba);
> > +       ret = ufshcd_query_attr_retry(hba,
> > UPIU_QUERY_OPCODE_WRITE_ATTR,
> > +                               QUERY_ATTR_IDN_WB_BUF_RESIZE_EN,
> > index, 0, &en_mode);
> > +       if (ret)
> > +               dev_err(hba->dev, "%s: Enable WB buf resize operation
> > failed %d\n",
> > +                       __func__, ret);
> > +
> > +       return ret;
> > +

Bean sir,

Thanks for you reply! 
Is the patch below okay?
https://lore.kernel.org/all/20250407085143.173-1-tanghuan@vivo.com/