linux-kernel - Re: [PATCH 06/12] gpio: f7188: use new line value setter callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_OUkBr4ayDimp5Z@smile.fi.intel.com>
Date: Mon, 7 Apr 2025 12:02:08 +0300
From: Andy Shevchenko <andy@...nel.org>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Linus Walleij <linus.walleij@...aro.org>,
	Orson Zhai <orsonzhai@...il.com>,
	Baolin Wang <baolin.wang@...ux.alibaba.com>,
	Chunyan Zhang <zhang.lyra@...il.com>,
	Peter Tyser <ptyser@...-inc.com>, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 06/12] gpio: f7188: use new line value setter callbacks

On Mon, Apr 07, 2025 at 09:13:15AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> struct gpio_chip now has callbacks for setting line values that return
> an integer, allowing to indicate failures. Convert the driver to using
> them.

...

> -static void f7188x_gpio_set(struct gpio_chip *chip, unsigned offset, int value);
> +static int f7188x_gpio_set(struct gpio_chip *chip, unsigned int offset,
> +			   int value);

Same comment, I suggest you to correct editor configuration to make sure
80 is 80 and not seventy something.

...

> -static void f7188x_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
> +static int f7188x_gpio_set(struct gpio_chip *chip, unsigned int offset,
> +			   int value)

Ditto.

...

But personally I would leave that archaism in the last decade or even century.

-- 
With Best Regards,
Andy Shevchenko