lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <36c30069-3e7a-495c-8225-acd080732485@kernel.org>
Date: Mon, 7 Apr 2025 11:57:37 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Pengyu Luo <mitltlatltl@...il.com>, Jianhua Lu <lujianhua000@...il.com>,
 Lee Jones <lee@...nel.org>, Daniel Thompson <danielt@...nel.org>,
 Jingoo Han <jingoohan1@...il.com>, Pavel Machek <pavel@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Helge Deller <deller@....de>
Cc: dri-devel@...ts.freedesktop.org, linux-leds@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-fbdev@...r.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: backlight: kinetic,ktz8866: add ktz8866
 slave compatible

On 07/04/2025 11:51, Pengyu Luo wrote:
> Kinetic ktz8866, found in many android devices, nowadays, some oem use
> dual ktz8866 to support a larger panel and  higher brightness, add the

Just one space after 'and'.

> binding for slave case.
> 
> Signed-off-by: Pengyu Luo <mitltlatltl@...il.com>
> ---
>  .../leds/backlight/kinetic,ktz8866.yaml       | 29 +++++++++++++++----
>  1 file changed, 24 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> index c914e1276..825a6fbf1 100644
> --- a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> +++ b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> @@ -19,7 +19,9 @@ allOf:
>  
>  properties:
>    compatible:
> -    const: kinetic,ktz8866
> +    enum:
> +      - kinetic,ktz8866
> +      - kinetic,ktz8866-slave

Does not look right. That's the same device. Same devices have same
compatible.

>  
>    reg:
>      maxItems: 1
> @@ -58,9 +60,16 @@ properties:
>  required:
>    - compatible
>    - reg
> -  - vddpos-supply
> -  - vddneg-supply
> -  - enable-gpios
> +
> +if:
> +  properties:
> +    compatible:
> +      const: kinetic,ktz8866
> +then:
> +  required:
> +    - vddpos-supply
> +    - vddneg-supply
> +    - enable-gpios

I don't understand why other device does not need power.

>  
>  unevaluatedProperties: false
>  
> @@ -68,7 +77,7 @@ examples:
>    - |
>      #include <dt-bindings/gpio/gpio.h>
>  
> -    i2c {
> +    i2c0 {

No, don't change.

>          #address-cells = <1>;
>          #size-cells = <0>;
>  
> @@ -84,3 +93,13 @@ examples:
>              kinetic,enable-lcd-bias;
>          };
>      };
> +
> +    i2c1 {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        backlight@11 {
> +            compatible = "kinetic,ktz8866-slave";
> +            reg = <0x11>;

No real differences here, so drop the example. Anyway, new examples
would start from - | (see other bindings).



Best regards,
Krzysztof

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ