linux-kernel - Re: [PATCH 1/4] block: factor out a helper to set logical/physical block size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e030fad-7f46-6fab-faa3-9727835f02ee@huaweicloud.com>
Date: Mon, 7 Apr 2025 19:25:41 +0800
From: Li Nan <linan666@...weicloud.com>
To: Bart Van Assche <bvanassche@....org>, linan666@...weicloud.com,
 axboe@...nel.dk, song@...nel.org, yukuai3@...wei.com, hare@...e.de,
 martin.petersen@...cle.com
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-raid@...r.kernel.org, wanghai38@...wei.com
Subject: Re: [PATCH 1/4] block: factor out a helper to set logical/physical
 block size

Hi, Bart:

Apologies for the delayed response.

在 2025/3/4 22:32, Bart Van Assche 写道:
> On 3/4/25 4:19 AM, linan666@...weicloud.com wrote:
>> +EXPORT_SYMBOL(blk_set_block_size);
> 
> This function is exported without documenting what the requirements are
> for calling this function? Yikes.
> 

Thank you for your reply, I'll add more
documentation in the next version.


> Is my understanding correct that it is only safe to apply changes made with 
> blk_set_block_size() by calling
> queue_limits_commit_update_frozen()?
> 

Exported func blk_set_block_size() is only used in RAID, with expected
usage similar to queue_limits_stack_bdev(): callers must ensure no pending
IO and use queue_limits_start_update/queue_limits_commit_update to prevent
concurrent modifications.

> Thanks,
> 
> Bart.
> 
> 
> .

-- 
Thanks,
Nan