linux-kernel - Re: [PATCH v1 3/3] drm/ci: Add jobs to run KUnit tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250407-laughing-mauve-cricket-86e1e0@houat>
Date: Mon, 7 Apr 2025 14:35:06 +0200
From: Maxime Ripard <mripard@...nel.org>
To: Vignesh Raman <vignesh.raman@...labora.com>
Cc: dri-devel@...ts.freedesktop.org, daniels@...labora.com, 
	helen.fornazier@...il.com, airlied@...il.com, simona.vetter@...ll.ch, robdclark@...il.com, 
	guilherme.gallo@...labora.com, sergi.blanch.torne@...labora.com, valentine.burley@...labora.com, 
	lumag@...nel.org, quic_abhinavk@...cinc.com, maarten.lankhorst@...ux.intel.com, 
	tzimmermann@...e.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 3/3] drm/ci: Add jobs to run KUnit tests

On Tue, Apr 01, 2025 at 07:47:16AM +0530, Vignesh Raman wrote:
> On 28/03/25 20:40, Maxime Ripard wrote:
> > On Thu, Mar 27, 2025 at 09:31:12PM +0530, Vignesh Raman wrote:
> > > Add jobs to run KUnit tests using tools/testing/kunit/kunit.py tool.
> > > 
> > > Signed-off-by: Vignesh Raman <vignesh.raman@...labora.com>
> > > ---
> > >   drivers/gpu/drm/ci/gitlab-ci.yml |  1 +
> > >   drivers/gpu/drm/ci/kunit.sh      | 34 ++++++++++++++++++++++++++++++++
> > >   drivers/gpu/drm/ci/kunit.yml     | 19 ++++++++++++++++++
> > >   3 files changed, 54 insertions(+)
> > >   create mode 100755 drivers/gpu/drm/ci/kunit.sh
> > >   create mode 100644 drivers/gpu/drm/ci/kunit.yml
> > > 
> > > diff --git a/drivers/gpu/drm/ci/gitlab-ci.yml b/drivers/gpu/drm/ci/gitlab-ci.yml
> > > index 9e61b49e9960..90ae57ca86a1 100644
> > > --- a/drivers/gpu/drm/ci/gitlab-ci.yml
> > > +++ b/drivers/gpu/drm/ci/gitlab-ci.yml
> > > @@ -109,6 +109,7 @@ include:
> > >     - drivers/gpu/drm/ci/build.yml
> > >     - drivers/gpu/drm/ci/test.yml
> > >     - drivers/gpu/drm/ci/check-devicetrees.yml
> > > +  - drivers/gpu/drm/ci/kunit.yml
> > >     - 'https://gitlab.freedesktop.org/gfx-ci/lab-status/-/raw/main/lab-status.yml'
> > > diff --git a/drivers/gpu/drm/ci/kunit.sh b/drivers/gpu/drm/ci/kunit.sh
> > > new file mode 100755
> > > index 000000000000..197b19d05fba
> > > --- /dev/null
> > > +++ b/drivers/gpu/drm/ci/kunit.sh
> > > @@ -0,0 +1,34 @@
> > > +#!/bin/bash
> > > +# SPDX-License-Identifier: MIT
> > > +
> > > +set -euxo pipefail
> > > +
> > > +case "${KERNEL_ARCH}" in
> > > +    "arm")
> > > +        QEMU_PKG="qemu-system-arm"
> > > +        GCC_ARCH="arm-linux-gnueabihf"
> > > +        ;;
> > > +    "arm64")
> > > +        QEMU_PKG="qemu-system-aarch64"
> > > +        GCC_ARCH="aarch64-linux-gnu"
> > > +        ;;
> > > +    "x86_64")
> > > +        QEMU_PKG="qemu-system-x86"
> > > +        GCC_ARCH="x86_64-linux-gnu"
> > > +        ;;
> > > +    *)
> > > +        echo "Unsupported architecture: ${KERNEL_ARCH}"
> > > +        exit 1
> > > +        ;;
> > > +esac
> > > +
> > > +export ARCH="${KERNEL_ARCH}"
> > > +export CROSS_COMPILE="${GCC_ARCH}-"
> > > +
> > > +apt-get update -qq && apt-get install -y --no-install-recommends "${QEMU_PKG}"
> > 
> > Thanks for working on that.
> > 
> > I'm a bit concerned about using making it entirely debian specific here.
> > Between the call to apt, the gcc triplet and the qemu package name, this
> > not really a script to run kunit tests, but to run them on Debian :)
> > 
> > We should make it pretty explicit and / or just assume the runner has
> > the right packages and call kunit directly.
> 
> Agree. This script is debian specific. I will move the debian bits to yaml
> job and make the script generic.

Using LLVM there is probably more convenient, since you don't have to
deal with the triplet at all when cross-compiling.

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)