linux-kernel - Re: [PATCH] net/mlx5: Fix null-ptr-deref in mlx5_create_inner_ttc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ddf49e1-eea3-4a20-b6f2-fc365b821dea@web.de>
Date: Tue, 8 Apr 2025 14:25:55 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Paolo Abeni <pabeni@...hat.com>, Henry Martin <bsdhenrymartin@...il.com>,
 linux-rdma@...r.kernel.org, netdev@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, Amir Tzin <amirtz@...dia.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, Aya Levin <ayal@...dia.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Leon Romanovsky <leon@...nel.org>,
 Saeed Mahameed <saeedm@...dia.com>, Simon Horman <horms@...nel.org>,
 Tariq Toukan <tariqt@...dia.com>
Subject: Re: [PATCH] net/mlx5: Fix null-ptr-deref in
 mlx5_create_inner_ttc_table()

…
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_ttc.c
> > @@ -655,6 +655,8 @@ struct mlx5_ttc_table *mlx5_create_inner_ttc_table(struct mlx5_core_dev *dev,
> >  	}
> >
> >  	ns = mlx5_get_flow_namespace(dev, params->ns_type);
> > +	if (!ns)
> > +		return ERR_PTR(-EOPNOTSUPP);
>
> I suspect the ns_type the caller always sets a valid 'ns_type', so the
> NULL ptr is not really possible here.

Is there a need to mark such a check result as “unlikely”?

Regards,
Markus