linux-kernel - Re: [PATCH v2 3/3] usb: renesas_usbhs: Reorder clock handling and power management in probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+V-a8uNMVcKZgJwZKptOB62UyFD==t0HPOc4j2GwaKwRrzKQg@mail.gmail.com>
Date: Tue, 8 Apr 2025 13:45:04 +0100
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Geert Uytterhoeven <geert+renesas@...der.be>, 
	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>, 
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>, Biju Das <biju.das.jz@...renesas.com>, 
	Claudiu Beznea <claudiu.beznea.uj@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH v2 3/3] usb: renesas_usbhs: Reorder clock handling and
 power management in probe

Hi Shimoda-san,

On Tue, Apr 8, 2025 at 1:37 PM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@...esas.com> wrote:
>
> Hello Prabhakar-san,
>
> > From: Yoshihiro Shimoda, Sent: Tuesday, April 8, 2025 7:40 PM
> <snip>
> > > @@ -721,7 +736,7 @@ static int usbhs_probe(struct platform_device *pdev)
> > >             if (ret) {
> > >                     dev_warn(dev, "USB function not selected (GPIO)\n");
> > >                     ret = -ENOTSUPP;
> > > -                   goto probe_end_mod_exit;
> > > +                   goto probe_assert_rest;
>
> nit:
> I think that the label name " probe_assert_reset" or " probe_assert_rst" is better.
>
I'll fix this in v3 to use `probe_assert_reset`.

> Anyway, I think that this patch seems good to me. So,
>
> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
>
> Also, I tested this patch on my environment (R-Car H3) and it doesn't have any regression.
> So,
>
> Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
>
Thank you for testing.

Cheers,
Prabhakar