linux-kernel - Re: [PATCH] drm/amd/pm/smu11: Prevent division by zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_NHD9ULZ21tApHk=c2z+brnms9XotGUvpOri8G3Df594g@mail.gmail.com>
Date: Tue, 8 Apr 2025 08:51:09 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: Denis Arefev <arefev@...mel.ru>
Cc: Jun.Ma2@....com, airlied@...il.com, alexander.deucher@....com, 
	amd-gfx@...ts.freedesktop.org, christian.koenig@....com, 
	dri-devel@...ts.freedesktop.org, kenneth.feng@....com, kevinyang.wang@....com, 
	lijo.lazar@....com, linux-kernel@...r.kernel.org, 
	lvc-project@...uxtesting.org, mario.limonciello@....com, simona@...ll.ch, 
	srinivasan.shanmugam@....com
Subject: Re: [PATCH] drm/amd/pm/smu11: Prevent division by zero

Oh, sorry, I've picked it up now.  Thanks!

Alex

On Tue, Apr 8, 2025 at 4:16 AM Denis Arefev <arefev@...mel.ru> wrote:
>
> > ---
> >  drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c
> > index 189c6a32b6bd..54229b991858 100644
> > --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c
> > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c
> > @@ -1200,7 +1200,7 @@ int smu_v11_0_set_fan_speed_rpm(struct smu_context *smu,
> >         uint32_t crystal_clock_freq = 2500;
> >         uint32_t tach_period;
> >
> > -       if (speed == 0)
> > +       if (!speed || speed > UINT_MAX/8)
> >                 return -EINVAL;
> >         /*
> >          * To prevent from possible overheat, some ASICs may have requirement
> > --
> > 2.43.0
> >
>
> Hi Alex.
>
> The patch 'drm/amd/pm/smu11: Prevent division by zero' was sent
> separately, not part of the patch series, maybe that's why it wasn't
> accepted. Should I resend it?
>
> Regards, Denis.
>