linux-kernel - RE: Recent changes mean sb_min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dd0001dba887$cbe78280$63b68780$@samsung.com>
Date: Tue, 8 Apr 2025 22:11:53 +0900
From: "Sungjong Seo" <sj1557.seo@...sung.com>
To: "'Jan Kara'" <jack@...e.cz>, "'Phillip Lougher'"
	<phillip@...ashfs.org.uk>
Cc: "'Andreas Gruenbacher'" <agruenba@...hat.com>, "'Namjae Jeon'"
	<linkinjeon@...nel.org>, "'OGAWA Hirofumi'" <hirofumi@...l.parknet.co.jp>,
	"'Carlos Maiolino'" <cem@...nel.org>, "'Darrick J. Wong'"
	<djwong@...nel.org>, <linux-fsdevel@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, "'Luis	Chamberlain'" <mcgrof@...nel.org>,
	<sjdev.seo@...il.com>, <sj1557.seo@...sung.com>, <cpgs@...sung.com>
Subject: RE: Recent changes mean sb_min_blocksize() can now fail

Hi, All

> Hi!
> 
> On Tue 08-04-25 06:33:53, Phillip Lougher wrote:
> > A recent (post 6.14) change to the kernel means sb_min_blocksize() can
> now fail,
> > and any filesystem which doesn't check the result may behave
> unexpectedly as a
> > result.  This change has recently affected Squashfs, and checking the
> kernel code,
> > a number of other filesystems including isofs, gfs2, exfat, fat and xfs
> do not
> > check the result.  This is a courtesy email to warn others of this
> change.
> >
> > The following emails give the relevant details.
> >
> > https://lore.kernel.org/all/2a13ea1c-08df-4807-83d4-
> 241831b7a2ec@...ashfs.org.uk/
> > https://lore.kernel.org/all/129d4f39-6922-44e9-8b1c-
> 6455ee564dda@...ashfs.org.uk/
> 
> Indeed. Thanks for the heads up!
> 
> 								Honza
> --
> Jan Kara <jack@...e.com>
> SUSE Labs, CR

exfat-fs calls it to set it to the minimum value of 512, but it's not
particularly problematic if it fails.

Thank you
B.R.
Sungjong Seo