linux-kernel - Re: [PATCH v3 4/6] x86/bugs: Don't fill RSB on VMEXIT with eIBRS+retpoline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9c081b6-3a92-4c46-be04-19abdb1ca429@suse.com>
Date: Tue, 8 Apr 2025 16:50:42 +0300
From: Nikolay Borisov <nik.borisov@...e.com>
To: Josh Poimboeuf <jpoimboe@...nel.org>, x86@...nel.org
Cc: linux-kernel@...r.kernel.org, amit@...nel.org, kvm@...r.kernel.org,
 amit.shah@....com, thomas.lendacky@....com, bp@...en8.de,
 tglx@...utronix.de, peterz@...radead.org, pawan.kumar.gupta@...ux.intel.com,
 corbet@....net, mingo@...hat.com, dave.hansen@...ux.intel.com,
 hpa@...or.com, seanjc@...gle.com, pbonzini@...hat.com,
 daniel.sneddon@...ux.intel.com, kai.huang@...el.com, sandipan.das@....com,
 boris.ostrovsky@...cle.com, Babu.Moger@....com, david.kaplan@....com,
 dwmw@...zon.co.uk, andrew.cooper3@...rix.com
Subject: Re: [PATCH v3 4/6] x86/bugs: Don't fill RSB on VMEXIT with
 eIBRS+retpoline



On 2.04.25 г. 21:19 ч., Josh Poimboeuf wrote:
> eIBRS protects against guest->host RSB underflow/poisoning attacks.
> Adding retpoline to the mix doesn't change that.  Retpoline has a
> balanced CALL/RET anyway.
> 
> So the current full RSB filling on VMEXIT with eIBRS+retpoline is
> overkill.  Disable it or do the VMEXIT_LITE mitigation if needed.
> 
> Suggested-by: Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>
> Reviewed-by: Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>
> Reviewed-by: Amit Shah <amit.shah@....com>
> Signed-off-by: Josh Poimboeuf <jpoimboe@...nel.org>

Reviewed-by: Nikolay Borisov <nik.borisov@...e.com>