linux-kernel - Re: [PATCH net v2] net: ethtool: Don't call .cleanup_data when prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <174412105573.1926106.14278610870424397090.git-patchwork-notify@kernel.org>
Date: Tue, 08 Apr 2025 14:04:15 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Maxime Chevallier <maxime.chevallier@...tlin.com>
Cc: davem@...emloft.net, andrew@...n.ch, kuba@...nel.org, edumazet@...gle.com,
 pabeni@...hat.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 thomas.petazzoni@...tlin.com, horms@...nel.org, mkubecek@...e.cz,
 f.fainelli@...il.com, kory.maincent@...tlin.com
Subject: Re: [PATCH net v2] net: ethtool: Don't call .cleanup_data when
 prepare_data fails

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@...hat.com>:

On Mon,  7 Apr 2025 15:05:10 +0200 you wrote:
> There's a consistent pattern where the .cleanup_data() callback is
> called when .prepare_data() fails, when it should really be called to
> clean after a successful .prepare_data() as per the documentation.
> 
> Rewrite the error-handling paths to make sure we don't cleanup
> un-prepared data.
> 
> [...]

Here is the summary with links:
  - [net,v2] net: ethtool: Don't call .cleanup_data when prepare_data fails
    https://git.kernel.org/netdev/net/c/4f038a6a02d2

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html