linux-kernel - Re: [PATCH 2/2] fuse: Adjust readdir() buffer to requesting buffer size.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d42dec00-513c-49d4-b4f3-d7a6ae387a6b@fastmail.fm>
Date: Tue, 8 Apr 2025 16:19:51 +0200
From: Bernd Schubert <bernd.schubert@...tmail.fm>
To: Miklos Szeredi <miklos@...redi.hu>, Jaco Kroon <jaco@....co.za>
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
 christophe.jaillet@...adoo.fr, joannelkoong@...il.com,
 rdunlap@...radead.org, trapexit@...wn.link, david.laight.linux@...il.com
Subject: Re: [PATCH 2/2] fuse: Adjust readdir() buffer to requesting buffer
 size.

On 4/1/25 17:33, Miklos Szeredi wrote:
> On Tue, 1 Apr 2025 at 17:04, Jaco Kroon <jaco@....co.za> wrote:
> 
>> Because fuse_simple_request via fuse_args_pages (ap) via fuse_io_args
>> (ia) expects folios and changing that is more than what I'm capable off,
>> and has larger overall impact.
> 
> Attaching a minimally tested patch.

Just tested this and looks good to me. Could we change to

-	size_t bufsize = 131072;
+	size_t bufsize = fc->max_pages << PAGE_SHIFT;

?

I'm testing with that in my branch, going to run xfstests over night.

Reviewed-by: Bernd Schubert <bschubert@....com>

Thanks,
Bernd