linux-kernel - Re: [PATCH v3 0/7] i2c: core: Move client towards fwnode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_U8Bza932tsZO66@kekkonen.localdomain>
Date: Tue, 8 Apr 2025 15:08:55 +0000
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
	Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
	Jai Luthra <jai.luthra@...asonboard.com>,
	Wolfram Sang <wsa+renesas@...g-engineering.com>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org,
	Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH v3 0/7] i2c: core: Move client towards fwnode

On Tue, Apr 08, 2025 at 05:48:53PM +0300, Andy Shevchenko wrote:
> On Tue, Apr 08, 2025 at 02:43:40PM +0000, Sakari Ailus wrote:
> > On Mon, Apr 07, 2025 at 06:44:56PM +0300, Andy Shevchenko wrote:
> > > The struct i2c_board_info has of_node and fwnode members. This is quite
> > > confusing as they are of the same semantics and it's tend to have an issue
> > > if user assigns both. Luckily there is only a single driver that does this
> > > and fix is provided in the last patch. Nevertheless the series moves
> > > the client handling code to use fwnode and deprecates the of_node member
> > > in the respective documentation.
> > > 
> > > Tomi tested the last patch, but since it was separate there is no tag (yet).
> > 
> > Apart from the two minor commit message comments:
> > 
> > Reviewed-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
> 
> Thank you for your review!
> Does it imply that media patch can go via I²C subsystem?

Good point. Yes, and you can use this for the last patch:

Acked-by: Sakari Ailus <sakari.ailus@...ux.intel.com>

I wonder if Tomi would still be able to test (or at least ack) it. I see he
has tested the rest but this one is missing hist Tested-by:.

-- 
Sakari Ailus