linux-kernel - Re: [PATCH v2] arm64: dts: imx8mp: Add device tree for Nitrogen8M Plus ENC Carrier Board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <196162332ff.b61ad5b5564260.8672918780815538746@collabora.com>
Date: Tue, 08 Apr 2025 17:02:07 +0100
From: Martyn Welch <martyn.welch@...labora.com>
To: "Andrew Lunn" <andrew@...n.ch>
Cc: "Rob Herring" <robh@...nel.org>,
	"Krzysztof Kozlowski" <krzk+dt@...nel.org>,
	"Conor Dooley" <conor+dt@...nel.org>,
	"Shawn Guo" <shawnguo@...nel.org>,
	"Sascha Hauer" <s.hauer@...gutronix.de>,
	"Pengutronix Kernel Team" <kernel@...gutronix.de>,
	"Fabio Estevam" <festevam@...il.com>,
	"kernel" <kernel@...labora.com>,
	"devicetree" <devicetree@...r.kernel.org>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	"imx" <imx@...ts.linux.dev>,
	"linux-arm-kernel" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2] arm64: dts: imx8mp: Add device tree for Nitrogen8M
 Plus ENC Carrier Board

 ---- On Thu, 27 Mar 2025 14:25:38 +0000  Andrew Lunn <andrew@...n.ch> wrote --- 
 > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-nitrogen-som.dtsi
 > > @@ -0,0 +1,415 @@
 > > +&eqos {
 > > +    pinctrl-names = "default";
 > > +    pinctrl-0 = <&pinctrl_eqos>;
 > > +    phy-handle = <&ethphy0>;
 > > +    phy-mode = "rgmii-id";
 > > +    status = "okay";
 > > +
 > > +    mdio {
 > > +        compatible = "snps,dwmac-mdio";
 > > +        #address-cells = <1>;
 > > +        #size-cells = <0>;
 > > +
 > > +        ethphy0: ethernet-phy@4 {
 > 
 > Just conformation, the PHY is on the SOM? Are the magnetics and RJ45
 > socket on the SOM, or the carrier?
 > 

The PHY is on the SOM, the magnetics and RJ45 socket are on the carrier.

 > > +            compatible = "ethernet-phy-ieee802.3-c22";
 > > +            reg = <4>;
 > > +            eee-broken-1000t;
 > 
 > > +#if 0
 > > +            interrupts-extended = <&gpio3 2 IRQ_TYPE_LEVEL_LOW>;
 > > +            reset-gpios = <&gpio3 16 GPIO_ACTIVE_LOW>;
 > > +#endif
 > 
 > Please don't have disabled properties.
 > 

ack.

 > > +            reg-mask = <0x90>;
 > 
 > What does this property do? It is not one i recognise.
 > 

Good question. Seems I missed quite a few bits whilst trying to clean this DTB up. Will try again....

Martyn

 >      Andrew
 >