linux-kernel - Re: [PATCH] crypto/testmgr: Fix acomp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_Skef-ZAYAzPfOF@gondor.apana.org.au>
Date: Tue, 8 Apr 2025 12:22:17 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Li Zhijian <lizhijian@...itsu.com>
Cc: davem@...emloft.net, linux-crypto@...r.kernel.org,
	mcoquelin.stm32@...il.com, alexandre.torgue@...s.st.com,
	linux-stm32@...md-mailman.stormreply.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Erhard Furtner <erhard_f@...lbox.org>
Subject: Re: [PATCH] crypto/testmgr: Fix acomp_req leak

On Tue, Apr 08, 2025 at 12:16:47PM +0800, Li Zhijian wrote:
> The kmemleak reported that
> ...
> unreferenced object 0xffff888108d6c300 (size 256):
>   comm "cryptomgr_test", pid 183, jiffies 4294700957
>   hex dump (first 32 bytes):
>     00 c1 d6 08 81 88 ff ff 00 cb d6 08 81 88 ff ff  ................
>     50 cd a7 81 ff ff ff ff b8 fb 93 02 00 c9 ff ff  P...............
>   backtrace (crc 29cca632):
>     __kmalloc_noprof+0x2fa/0x430
>     test_acomp+0x174/0x960
>     alg_test_comp+0x6f/0x90
>     alg_test.part.26+0x105/0x410
>     cryptomgr_test+0x20/0x40
>     kthread+0x10c/0x250
>     ret_from_fork+0x30/0x40
>     ret_from_fork_asm+0x1a/0x30
> unreferenced object 0xffff888108d6c100 (size 256):
>   comm "cryptomgr_test", pid 183, jiffies 4294700972
>   hex dump (first 32 bytes):
>     00 1d da 08 81 88 ff ff 00 c3 d6 08 81 88 ff ff  ................
>     50 cd a7 81 ff ff ff ff b8 fb 93 02 00 c9 ff ff  P...............
>   backtrace (crc 3047d62b):
>     __kmalloc_noprof+0x2fa/0x430
>     test_acomp+0x174/0x960
>     alg_test_comp+0x6f/0x90
>     alg_test.part.26+0x105/0x410
>     cryptomgr_test+0x20/0x40
>     kthread+0x10c/0x250
>     ret_from_fork+0x30/0x40
>     ret_from_fork_asm+0x1a/0x30
> 
> acomp_request will be chained to req[0], however,
> acomp_request_free(), it will not free the whole chain.
> 
> Fix it by freeing them one by one.
> 
> Fixes: 99585c2192cb ("crypto: testmgr - Add multibuffer acomp testing")
> Reported-by: Erhard Furtner <erhard_f@...lbox.org>
> Closes: https://lore.kernel.org/linux-crypto/20250408002741.089f1e9a@outsider.home/
> Signed-off-by: Li Zhijian <lizhijian@...itsu.com>
> ---
>  crypto/testmgr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for the patch but this will be removed by

https://patchwork.kernel.org/project/linux-crypto/patch/048b1e176dd3507ec31497ccf215630dc2b2ed04.1744018301.git.herbert@gondor.apana.org.au/

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt