linux-kernel - Re: Recent changes mean sb_min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <z3tovmo2cxgkvesiyrrvhnd3nk2qgogt6553hyxrmmodoiptdh@4hahwdkhx7da>
Date: Tue, 8 Apr 2025 13:36:25 -0400
From: Kent Overstreet <kent.overstreet@...ux.dev>
To: Phillip Lougher <phillip@...ashfs.org.uk>
Cc: Jan Kara <jack@...e.cz>, Andreas Gruenbacher <agruenba@...hat.com>, 
	Namjae Jeon <linkinjeon@...nel.org>, Sungjong Seo <sj1557.seo@...sung.com>, 
	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>, Carlos Maiolino <cem@...nel.org>, 
	"Darrick J. Wong" <djwong@...nel.org>, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Luis Chamberlain <mcgrof@...nel.org>
Subject: Re: Recent changes mean sb_min_blocksize() can now fail

On Tue, Apr 08, 2025 at 06:33:53AM +0100, Phillip Lougher wrote:
> Hi,
> 
> A recent (post 6.14) change to the kernel means sb_min_blocksize() can now fail,
> and any filesystem which doesn't check the result may behave unexpectedly as a
> result.  This change has recently affected Squashfs, and checking the kernel code,
> a number of other filesystems including isofs, gfs2, exfat, fat and xfs do not
> check the result.  This is a courtesy email to warn others of this change.
> 
> The following emails give the relevant details.
> 
> https://lore.kernel.org/all/2a13ea1c-08df-4807-83d4-241831b7a2ec@squashfs.org.uk/
> https://lore.kernel.org/all/129d4f39-6922-44e9-8b1c-6455ee564dda@squashfs.org.uk/
> 
> Regards
> 
> Phillip

this would be a good time to use __must_check