linux-kernel - Re: [PATCH v1 10/10] cpufreq: Pass policy pointer to ->update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e10c4f6cfff8cd55cfe53de5bd1965e26d3ae8e6.camel@linux.intel.com>
Date: Tue, 08 Apr 2025 11:48:43 -0700
From: srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
To: "Rafael J. Wysocki" <rafael@...nel.org>
Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>, Linux PM
 <linux-pm@...r.kernel.org>,  LKML <linux-kernel@...r.kernel.org>, Viresh
 Kumar <viresh.kumar@...aro.org>, Mario Limonciello
 <mario.limonciello@....com>, Sudeep Holla <sudeep.holla@....com>
Subject: Re: [PATCH v1 10/10] cpufreq: Pass policy pointer to
 ->update_limits()

On Tue, 2025-04-08 at 20:34 +0200, Rafael J. Wysocki wrote:
> On Tue, Apr 8, 2025 at 7:47 PM srinivas pandruvada
> <srinivas.pandruvada@...ux.intel.com> wrote:
> > 
> > On Tue, 2025-04-08 at 15:37 +0200, Rafael J. Wysocki wrote:
> > > On Tue, Apr 8, 2025 at 1:41 PM Rafael J. Wysocki
> > > <rafael@...nel.org>
> > > wrote:
> > > > 
> > > > On Tue, Apr 8, 2025 at 12:28 AM srinivas pandruvada
> > > > <srinivas.pandruvada@...ux.intel.com> wrote:
> > > > > 
> > > > > On Mon, 2025-04-07 at 20:48 +0200, Rafael J. Wysocki wrote:
> > > > > > On Fri, Mar 28, 2025 at 9:49 PM Rafael J. Wysocki
> > > > > > <rjw@...ysocki.net>
> > > > > > wrote:
> > > > > > > 
> > > > > > > From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> > > > > > > 
> > > > > > > Since cpufreq_update_limits() obtains a cpufreq policy
> > > > > > > pointer for
> > > > > > > the
> > > > > > > given CPU and reference counts the corresponding policy
> > > > > > > object, it
> > > > > > > may
> > > > > > > as well pass the policy pointer to the cpufreq driver's -
> > > > > > > > update_limits()
> > > > > > > callback which allows that callback to avoid invoking
> > > > > > > cpufreq_cpu_get()
> > > > > > > for the same CPU.
> > > > > > > 
> > > > > > > Accordingly, redefine ->update_limits() to take a policy
> > > > > > > pointer
> > > > > > > instead
> > > > > > > of a CPU number and update both drivers implementing it,
> > > > > > > intel_pstate
> > > > > > > and amd-pstate, as needed.
> > > > > > > 
> > > > > > > Signed-off-by: Rafael J. Wysocki
> > > > > > > <rafael.j.wysocki@...el.com>
> > > > > > 
> > > > > Hi Rafael,
> > > > > 
> > > > > > Hi Srinivas,
> > > > > > 
> > > > > > If you have any concerns regarding this patch, please let
> > > > > > me
> > > > > > know
> > > > > > (note that it is based on the [05/10]).
> > > > > > 
> > > > > Changes looks fine, but wants to test out some update limits
> > > > > from
> > > > > interrupt path.
> > > > > Checked your branches at linux-pm, not able to locate in any
> > > > > branch to
> > > > > apply.
> > > > > Please point me to a branch.
> > > > 
> > > > I'll put it in 'testing' later today.
> > > 
> > > Now available from
> > > 
> > > git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git
> > > testing
> > > 
> > Looks good.
> > 
> > Acked-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> 
> Thanks!
> 
> IIUC this applies to both [5/10] and [10/10], or please let me know
> if
> that's not the case.

This is for both. I tested the whole "testing" branch.

Thanks,
Srinivas