linux-kernel - Re: [PATCH] drm/msm/dpu: drop rogue intr_tear_rd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aba8d029-ab07-4658-8c0c-9d34f9b96a57@quicinc.com>
Date: Tue, 8 Apr 2025 12:34:15 -0700
From: Abhinav Kumar <quic_abhinavk@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
        Rob Clark
	<robdclark@...il.com>, Dmitry Baryshkov <lumag@...nel.org>,
        Sean Paul
	<sean@...rly.run>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        "David
 Airlie" <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
        Barnabás Czémán <barnabas.czeman@...nlining.org>,
        "Konrad Dybcio" <konradybcio@...nel.org>
CC: <linux-arm-msm@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <freedreno@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/msm/dpu: drop rogue intr_tear_rd_ptr values



On 4/8/2025 6:02 AM, Dmitry Baryshkov wrote:
> The commit 5a9d50150c2c ("drm/msm/dpu: shift IRQ indices by 1") shifted
> IRQ indices by 1, making 'NO_IRQ' to be 0 rather than -1 (and allowing
> to skip the definition if the IRQ is not present).
> Several platform files were sketched before that commit, but got applied
> afterwards. As such, they inherited historical (and currently incorrect)
> setting of .intr_tear_rd_ptr = -1 for 'NO_IRQ' value.
> 
> Drop that setting for all the affected platforms.
> 
> Fixes: 62af6e1cb596 ("drm/msm/dpu: Add support for MSM8917")
> Fixes: c079680bb0fa ("drm/msm/dpu: Add support for MSM8937")
> Fixes: 7a6109ce1c2c ("drm/msm/dpu: Add support for MSM8953")
> Fixes: daf9a92daeb8 ("drm/msm/dpu: Add support for MSM8996")
> Fixes: 7204df5e7e68 ("drm/msm/dpu: add support for SDM660 and SDM630 platforms")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
> ---
>   drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_14_msm8937.h | 2 --
>   drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_15_msm8917.h | 1 -
>   drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_16_msm8953.h | 3 ---
>   drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_7_msm8996.h  | 4 ----
>   drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_2_sdm660.h   | 3 ---
>   drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_3_sdm630.h   | 2 --
>   6 files changed, 15 deletions(-)
> 

Reviewed-by: Abhinav Kumar <quic_abhinavk@...cinc.com>