linux-kernel - Re: [PATCH v3] platform/x86: thinkpad-acpi: Add error check for tpacpi_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <D90ZXBE1FIMF.2DV3D7QERNFMR@gmail.com>
Date: Tue, 08 Apr 2025 02:08:45 -0300
From: "Kurt Borja" <kuurtb@...il.com>
To: "Wentao Liang" <vulab@...as.ac.cn>, <hmh@....eng.br>,
 <hdegoede@...hat.com>, <ilpo.jarvinen@...ux.intel.com>
Cc: <ibm-acpi-devel@...ts.sourceforge.net>,
 <platform-driver-x86@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <stable@...r.kernel.org>
Subject: Re: [PATCH v3] platform/x86: thinkpad-acpi: Add error check for
 tpacpi_check_quirks

Hi Wentao,

On Mon Apr 7, 2025 at 10:39 PM -03, Wentao Liang wrote:
> In tpacpi_battery_init(), the return value of tpacpi_check_quirks() needs
> to be checked. The battery should not be hooked if there is no matched
> battery information in quirk table.

Why is this the case? What problem is this fixing?

It seems only a few devices are listed in battery_quirk_table, and the
comment above it suggests it is just a fixup:

	/*
	 * Individual addressing is broken on models that expose the
	 * primary battery as BAT1.
	 */

Furthermore, I looked at uses of this quirk in the code and it's absence
doesn't seem critical.

>
> Add an error check and return -ENODEV immediately if the device fail
> the check.

I bring this up because it has the potential to cause a regression on a
lot of devices.

-- 
 ~ Kurt