linux-kernel - Re: [PATCH] tests/pid_namespace: Add missing sys/mount.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <803bf3ec-08ff-49c5-8bf1-1fa27f2477e7@linuxfoundation.org>
Date: Tue, 8 Apr 2025 16:48:01 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: "T.J. Mercier" <tjmercier@...gle.com>,
 Christian Brauner <brauner@...nel.org>, Shuah Khan <shuah@...nel.org>,
 Alexander Mikhalitsyn <alexander@...alicyn.com>
Cc: linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] tests/pid_namespace: Add missing sys/mount.h

On 4/7/25 16:59, T.J. Mercier wrote:
> pid_max.c: In function ‘pid_max_cb’:
> pid_max.c:42:15: error: implicit declaration of function ‘mount’
>                                         [-Wimplicit-function-declaration]
>     42 |         ret = mount("", "/", NULL, MS_PRIVATE | MS_REC, 0);
>        |               ^~~~~
> pid_max.c:42:36: error: ‘MS_PRIVATE’ undeclared (first use in this
>                                    function); did you mean ‘MAP_PRIVATE’?
>     42 |         ret = mount("", "/", NULL, MS_PRIVATE | MS_REC, 0);
>        |                                    ^~~~~~~~~~
>        |                                    MAP_PRIVATE
> pid_max.c:42:49: error: ‘MS_REC’ undeclared (first use in this function)
>     42 |         ret = mount("", "/", NULL, MS_PRIVATE | MS_REC, 0);
>        |                                                 ^~~~~~
> pid_max.c:48:9: error: implicit declaration of function ‘umount2’; did
>                 you mean ‘SYS_umount2’? [-Wimplicit-function-declaration]
>     48 |         umount2("/proc", MNT_DETACH);
>        |         ^~~~~~~
>        |         SYS_umount2
> pid_max.c:48:26: error: ‘MNT_DETACH’ undeclared (first use in this
>                                                                 function)
>     48 |         umount2("/proc", MNT_DETACH);
> 
> Fixes: 615ab43b838b ("tests/pid_namespace: add pid_max tests")
> Signed-off-by: T.J. Mercier <tjmercier@...gle.com>

Change the short log to include the subsystem. Send v2 with this
change.

selftests: pid_namespace: Add missing sys/mount.h

thanks,
-- Shuah