linux-kernel - Re: [PATCH] dmaengine: idxd: Remove unused pointer and macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a1a54ff1-8b14-4bd0-aba6-c23d8261fd9c@intel.com>
Date: Tue, 8 Apr 2025 15:47:52 -0700
From: Dave Jiang <dave.jiang@...el.com>
To: Eder Zulian <ezulian@...hat.com>, vinicius.gomes@...el.com,
 vkoul@...nel.org, dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: idxd: Remove unused pointer and macro



On 4/8/25 10:38 AM, Eder Zulian wrote:
> The pointer 'extern struct kmem_cache *idxd_desc_pool' and the macro
> '#define IDXD_ALLOCATED_BATCH_SIZE 128U' were introduced in commit
> bfe1d56091c1 ("dmaengine: idxd: Init and probe for Intel data
> accelerators") but they were never used.
> 
> Signed-off-by: Eder Zulian <ezulian@...hat.com>

Reviewed-by: Dave Jiang <dave.jiang@...el.com>
> ---
>  drivers/dma/idxd/idxd.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/dma/idxd/idxd.h b/drivers/dma/idxd/idxd.h
> index 214b8039439f..74e6695881e6 100644
> --- a/drivers/dma/idxd/idxd.h
> +++ b/drivers/dma/idxd/idxd.h
> @@ -19,7 +19,6 @@
>  
>  #define IDXD_DRIVER_VERSION	"1.00"
>  
> -extern struct kmem_cache *idxd_desc_pool;
>  extern bool tc_override;
>  
>  struct idxd_wq;
> @@ -171,7 +170,6 @@ struct idxd_cdev {
>  
>  #define DRIVER_NAME_SIZE		128
>  
> -#define IDXD_ALLOCATED_BATCH_SIZE	128U
>  #define WQ_NAME_SIZE   1024
>  #define WQ_TYPE_SIZE   10
>