linux-kernel - Re: [PATCH v6 1/2] staging: rtl8723bs: Add white spaces around binary operators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vfp8Je1fUavSwTDAM_5_rDaDfXETa2oM5f0CjL1mxWX_Q@mail.gmail.com>
Date: Tue, 8 Apr 2025 10:19:27 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Abraham Samuel Adekunle <abrahamadekunle50@...il.com>
Cc: outreachy@...ts.linux.dev, gregkh@...uxfoundation.org, 
	julia.lawall@...ia.fr, linux-staging@...ts.linux.dev, 
	linux-kernel@...r.kernel.org, david.laight.linux@...il.com, andy@...nel.org, 
	dan.carpenter@...aro.org
Subject: Re: [PATCH v6 1/2] staging: rtl8723bs: Add white spaces around binary operators

On Tue, Apr 8, 2025 at 12:54 AM Abraham Samuel Adekunle
<abrahamadekunle50@...il.com> wrote:
>
> The code contains no spaces around binary operators making it
> hard to read. This also doesn't adhere to Linux kernel coding
> style.
>
> Add white spaces around the binary operators to increase readability
> and endure adherence to Linux kernel coding styles.

...

> -                                               psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (tx_seq+1)&0xfff;
> +                                               psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (tx_seq + 1) & 0xfff;

> -                                               psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (pattrib->seqnum+1)&0xfff;
> +                                               psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (pattrib->seqnum + 1) & 0xfff;

You mentioned Linux coding style, which also requires lines not to be
so long. These lines are. That's why a few versions ago I suggested
you to change these to be two lines each. I don't know how many times
to repeat this (it's third one).

-- 
With Best Regards,
Andy Shevchenko