linux-kernel - Re: [PATCH] HID: appletb-kbd: Use secs_to_jiffies() instead of msecs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PN3PR01MB9597001E80B673AA1E4033C0B8B52@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>
Date: Tue, 8 Apr 2025 13:22:50 +0530
From: Aditya Garg <gargaditya08@...e.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>, Jiri Kosina <jikos@...nel.org>,
 Benjamin Tissoires <bentiss@...nel.org>
Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: appletb-kbd: Use secs_to_jiffies() instead of
 msecs_to_jiffies()



On 07/04/25 1:59 pm, Thorsten Blum wrote:
> Use secs_to_jiffies() instead of msecs_to_jiffies() and avoid scaling
> the module params 'appletb_tb_idle_timeout' and 'appletb_tb_dim_timeout'
> to milliseconds. secs_to_jiffies() expands to simpler code and reduces
> the size of 'hid-appletb-kbd.ko'.
> 
> Reformat the code to silence multiple checkpatch warnings.
> 
> No functional changes intended.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---

LGTM

Reviewed-by: Aditya Garg <gargaditya08@...e.com>
Tested-by: Aditya Garg <gargaditya08@...e.com>