linux-kernel - Re: [PATCH 06/10] panel/th101mb31ig002-28a: Use refcounted allocation in place of devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e976fa2c-88ce-44c3-807b-c6e6e414a28d@suse.de>
Date: Tue, 8 Apr 2025 10:24:17 +0200
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Anusha Srivatsa <asrivats@...hat.com>,
 Neil Armstrong <neil.armstrong@...aro.org>,
 Jessica Zhang <quic_jesszhan@...cinc.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Linus Walleij <linus.walleij@...aro.org>,
 Joel Selvaraj <jo@...amily.in>, Douglas Anderson <dianders@...omium.org>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 06/10] panel/th101mb31ig002-28a: Use refcounted allocation
 in place of devm_kzalloc()

Hi

this patch doesn't build.

linux/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c: In function 
‘boe_th101mb31ig002_dsi_probe’:
linux/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c:352:9: error: 
‘panel’ undeclared (first use in this function)
   352 |         panel = devm_drm_panel_alloc(dev, struct panel_desc, panel,
       |         ^~~~~
linux/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c:352:9: note: 
each undeclared identifier is reported only once for each function it 
appears in
In file included from 
linux/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c:18:
linux/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c:352:38: 
error: ‘dev’ undeclared (first use in this function); did you mean ‘cdev’?
   352 |         panel = devm_drm_panel_alloc(dev, struct panel_desc, panel,
       |                                      ^~~


Please fix.

Best regards
Thomas

Am 01.04.25 um 18:03 schrieb Anusha Srivatsa:
> Move to using the new API devm_drm_panel_alloc() to allocate the
> panel.
>
> Signed-off-by: Anusha Srivatsa <asrivats@...hat.com>
> ---
>   drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c | 11 +++++------
>   1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c b/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c
> index 0b87f1e6ecaea71f10a249bdc53466d281f07a34..7ae196424b6dfb731cd1ea48363c4fa1e6c36464 100644
> --- a/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c
> +++ b/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c
> @@ -349,9 +349,11 @@ static int boe_th101mb31ig002_dsi_probe(struct mipi_dsi_device *dsi)
>   	const struct panel_desc *desc;
>   	int ret;
>   
> -	ctx = devm_kzalloc(&dsi->dev, sizeof(*ctx), GFP_KERNEL);
> -	if (!ctx)
> -		return -ENOMEM;
> +	panel = devm_drm_panel_alloc(dev, struct panel_desc, panel,
> +				     &boe_th101mb31ig002_funcs,
> +				     DRM_MODE_CONNECTOR_DSI);
> +	if (IS_ERR(panel))
> +		return PTR_ERR(panel);
>   
>   	mipi_dsi_set_drvdata(dsi, ctx);
>   	ctx->dsi = dsi;
> @@ -383,9 +385,6 @@ static int boe_th101mb31ig002_dsi_probe(struct mipi_dsi_device *dsi)
>   		return dev_err_probe(&dsi->dev, ret,
>   				     "Failed to get orientation\n");
>   
> -	drm_panel_init(&ctx->panel, &dsi->dev, &boe_th101mb31ig002_funcs,
> -		       DRM_MODE_CONNECTOR_DSI);
> -
>   	ret = drm_panel_of_backlight(&ctx->panel);
>   	if (ret)
>   		return ret;
>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)