linux-kernel - Re: [PATCH v3 1/2] watchdog: Add driver for Intel OC WDT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <daeedd95-1d4a-4d17-baa1-9c1580095de9@siemens.com>
Date: Tue, 8 Apr 2025 09:31:37 +0100
From: Diogo Ivo <diogo.ivo@...mens.com>
To: "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>,
 Wim Van Sebroeck <wim@...ux-watchdog.org>, Guenter Roeck <linux@...ck-us.net>
Cc: linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
 linux-watchdog@...r.kernel.org, jan.kiszka@...mens.com,
 benedikt.niedermayr@...mens.com
Subject: Re: [PATCH v3 1/2] watchdog: Add driver for Intel OC WDT

Hello,

On 3/17/25 10:55 AM, Diogo Ivo wrote:
> Add a driver for the Intel Over-Clocking Watchdog found in Intel
> Platform Controller (PCH) chipsets. This watchdog is controlled
> via a simple single-register interface and would otherwise be
> standard except for the presence of a LOCK bit that can only be
> set once per power cycle, needing extra handling around it.
> 
> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> Signed-off-by: Diogo Ivo <diogo.ivo@...mens.com>
> ---
> v2->v3:
>   - Collect R-b from Guenter
> 
> v1->v2:
>   - Split v1 into two patches, adding the ACPI IDs in a separate patch
>   - Initialize hearbeat module parameter to zero
>   - Clarify wording around lock handling
>   - Properly print resource with %pR when failing to obtain it
>   - Enable compile testing and add dependency on HAS_IOPORT
>   - Drop unneeded ACPI_PTR() and MODULE_ALIAS()
> ---
> ---
>   drivers/watchdog/Kconfig        |  11 ++
>   drivers/watchdog/Makefile       |   1 +
>   drivers/watchdog/intel_oc_wdt.c | 233 ++++++++++++++++++++++++++++++++++++++++
>   3 files changed, 245 insertions(+)
> 

Gentle ping on this patch.

Best regards,
Diogo