linux-kernel - Re: [PATCH v6 1/2] staging: rtl8723bs: Add white spaces around binary operators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_TtyXwkOBK1MXGy@smile.fi.intel.com>
Date: Tue, 8 Apr 2025 12:35:05 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Samuel Abraham <abrahamadekunle50@...il.com>
Cc: outreachy@...ts.linux.dev, gregkh@...uxfoundation.org,
	julia.lawall@...ia.fr, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org, david.laight.linux@...il.com,
	dan.carpenter@...aro.org
Subject: Re: [PATCH v6 1/2] staging: rtl8723bs: Add white spaces around
 binary operators

On Tue, Apr 08, 2025 at 10:22:44AM +0100, Samuel Abraham wrote:
> On Tue, Apr 8, 2025 at 8:20 AM Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:
> > On Tue, Apr 8, 2025 at 12:54 AM Abraham Samuel Adekunle
> > <abrahamadekunle50@...il.com> wrote:

...

> > > -                                               psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (tx_seq+1)&0xfff;
> > > +                                               psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (tx_seq + 1) & 0xfff;
> >
> > > -                                               psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (pattrib->seqnum+1)&0xfff;
> > > +                                               psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (pattrib->seqnum + 1) & 0xfff;
> >
> > You mentioned Linux coding style, which also requires lines not to be
> > so long. These lines are. That's why a few versions ago I suggested
> > you to change these to be two lines each. I don't know how many times
> > to repeat this (it's third one).
> 
> Okay, sorry
> I will add a third patch for a line break before the patch for %
> operations since each patch should handle a single thing.

I am not sure you need a third patch for that. It lies into category of space
and indentation fix.

-- 
With Best Regards,
Andy Shevchenko