linux-kernel - Re: [RESEND Patch v2 1/3] maple_tree: Fix mt_destroy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mwv46z5wqetbxhrxgwppa3zj3ifjimjqkrlxu75e2byiurt7sq@mw4otg4rq4zy>
Date: Mon, 7 Apr 2025 21:43:47 -0400
From: "Liam R. Howlett" <Liam.Howlett@...cle.com>
To: Wei Yang <richard.weiyang@...il.com>
Cc: akpm@...ux-foundation.org, willy@...radead.org,
        linux-kernel@...r.kernel.org, maple-tree@...ts.infradead.org,
        linux-mm@...ck.org, stable@...r.kernel.org
Subject: Re: [RESEND Patch v2 1/3] maple_tree: Fix mt_destroy_walk() on root
 leaf node

* Wei Yang <richard.weiyang@...il.com> [250407 19:14]:
> On destroy, we should set each node dead. But current code miss this
> when the maple tree has only the root node.
> 
> The reason is mt_destroy_walk() leverage mte_destroy_descend() to set
> node dead, but this is skipped since the only root node is a leaf.
> 
> Fixes this by setting the node dead if it is a leaf.
> 
> Fixes: 54a611b60590 ("Maple Tree: add new data structure")
> Signed-off-by: Wei Yang <richard.weiyang@...il.com>
> CC: Liam R. Howlett <Liam.Howlett@...cle.com>
> Cc: <stable@...r.kernel.org>

Reviewed-by: Liam R. Howlett <Liam.Howlett@...cle.com>

> 
> ---
> v2:
>   * move the operation into mt_destroy_walk()
>   * adjust the title accordingly
> ---
>  lib/maple_tree.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index 4bd5a5be1440..0696e8d1c4e9 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -5284,6 +5284,7 @@ static void mt_destroy_walk(struct maple_enode *enode, struct maple_tree *mt,
>  	struct maple_enode *start;
>  
>  	if (mte_is_leaf(enode)) {
> +		mte_set_node_dead(enode);
>  		node->type = mte_node_type(enode);
>  		goto free_leaf;
>  	}
> -- 
> 2.34.1
>