linux-kernel - RE: [PATCH v2 1/3] usb: renesas_usbhs: Correct function references in comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TYCPR01MB11040F988A4F7040D4FB70746D8B52@TYCPR01MB11040.jpnprd01.prod.outlook.com>
Date: Tue, 8 Apr 2025 09:54:41 +0000
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To: Prabhakar <prabhakar.csengg@...il.com>, Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>, Geert Uytterhoeven <geert+renesas@...der.be>,
	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
CC: "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>, Biju
 Das <biju.das.jz@...renesas.com>, Claudiu Beznea
	<claudiu.beznea.uj@...renesas.com>, Fabrizio Castro
	<fabrizio.castro.jz@...esas.com>, Prabhakar Mahadev Lad
	<prabhakar.mahadev-lad.rj@...renesas.com>
Subject: RE: [PATCH v2 1/3] usb: renesas_usbhs: Correct function references in
 comment

Hello Prabhakar-san,

> From: Prabhakar, Sent: Monday, April 7, 2025 7:50 PM
> 
> Update the comment to reference `usbhs_mod_probe()` instead of
> `usbhs_mod_init()`, and replace `dev_set_drvdata()` with
> `platform_set_drvdata()`, as these are the correct functions used
> in this context.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>

Thank you for the patch!

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>

Best regards,
Yoshihiro Shimoda

> ---
>  drivers/usb/renesas_usbhs/common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
> index 4b35ef216125..03d4d40c90b3 100644
> --- a/drivers/usb/renesas_usbhs/common.c
> +++ b/drivers/usb/renesas_usbhs/common.c
> @@ -698,7 +698,7 @@ static int usbhs_probe(struct platform_device *pdev)
>  	if (ret < 0)
>  		goto probe_end_fifo_exit;
> 
> -	/* dev_set_drvdata should be called after usbhs_mod_init */
> +	/* platform_set_drvdata() should be called after usbhs_mod_probe() */
>  	platform_set_drvdata(pdev, priv);
> 
>  	ret = reset_control_deassert(priv->rsts);
> --
> 2.49.0