linux-kernel - Re: [PATCH 2/2] RAS/AMD/{ATL,FMPM}: Get masked address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250408101415.GEZ_T29wiuh-_sExlk@fat_crate.local>
Date: Tue, 8 Apr 2025 12:14:15 +0200
From: Borislav Petkov <bp@...en8.de>
To: Yazen Ghannam <yazen.ghannam@....com>
Cc: Naveen Krishna Chatradhi <naveenkrishna.chatradhi@....com>,
	Muralidhara M K <muralidhara.mk@....com>,
	linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] RAS/AMD/{ATL,FMPM}: Get masked address

On Mon, Apr 07, 2025 at 11:16:57AM -0400, Yazen Ghannam wrote:
> Okay, will do.

Yah, except that df_cfg crap needs an export now:

ERROR: modpost: "df_cfg" [drivers/ras/amd/fmpm.ko] undefined!
make[2]: *** [scripts/Makefile.modpost:147: Module.symvers] Error 1
make[1]: *** [/mnt/kernel/kernel/linux/Makefile:1956: modpost] Error 2
make: *** [Makefile:248: __sub-make] Error 2

Looking at the call chain how we land in that fpds_equal() in fmpm, can we
read out from the error records themselves that those are from MI300 and not
need df_cfg at all?

There's a struct mce here:

static void update_fru_record(struct fru_rec *rec, struct mce *m)

which has CPUID for example.

Otherwise we'll have to go back to your original thing if we're going to have
to export *something*...

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette