linux-kernel - Re: [PATCH v2 nf-next] docs: tproxy: fix formatting for nft code block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_T3onGJiXbbd8ST@archie.me>
Date: Tue, 8 Apr 2025 17:17:06 +0700
From: Bagas Sanjaya <bagasdotme@...il.com>
To: Chen Linxuan <chenlinxuan@...ontech.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>, Jonathan Corbet <corbet@....net>
Cc: Pablo Neira Ayuso <pablo@...filter.org>,
	Jozsef Kadlecsik <kadlec@...filter.org>,
	netfilter-devel@...r.kernel.org, coreteam@...filter.org,
	netdev@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 nf-next] docs: tproxy: fix formatting for nft code
 block

On Tue, Apr 08, 2025 at 03:35:50PM +0800, Chen Linxuan wrote:
> The nft command snippet for redirecting traffic isn't formatted
> in a literal code block like the rest of snippets.
> Fix the formatting inconsistency.
> 
> Signed-off-by: Chen Linxuan <chenlinxuan@...ontech.com>
> ---
> v2:
>   - Update commit message according to suggestion from Bagas
> v1: https://lore.kernel.org/all/CFD0AAF9D7040B1E+20250407031727.1615941-1-chenlinxuan@uniontech.com/
> ---
>  Documentation/networking/tproxy.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/networking/tproxy.rst b/Documentation/networking/tproxy.rst
> index 7f7c1ff6f159..75e4990cc3db 100644
> --- a/Documentation/networking/tproxy.rst
> +++ b/Documentation/networking/tproxy.rst
> @@ -69,9 +69,9 @@ add rules like this to the iptables ruleset above::
>      # iptables -t mangle -A PREROUTING -p tcp --dport 80 -j TPROXY \
>        --tproxy-mark 0x1/0x1 --on-port 50080
>  
> -Or the following rule to nft:
> +Or the following rule to nft::
>  
> -# nft add rule filter divert tcp dport 80 tproxy to :50080 meta mark set 1 accept
> +    # nft add rule filter divert tcp dport 80 tproxy to :50080 meta mark set 1 accept
>  
>  Note that for this to work you'll have to modify the proxy to enable (SOL_IP,
>  IP_TRANSPARENT) for the listening socket.

Looks good, thanks!

Reviewed-by: Bagas Sanjaya <bagasdotme@...il.com>

-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)