linux-kernel - Re: [RFC] PCI: add CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWN=wurw7qz0t2ovMkUNu0BJRAMv_0U63Lqs2MGxkVnHw@mail.gmail.com>
Date: Tue, 8 Apr 2025 12:22:23 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>, Arnd Bergmann <arnd@...db.de>, 
	Jeff Hugo <jeff.hugo@....qualcomm.com>, Carl Vanderlip <quic_carlv@...cinc.com>, 
	Oded Gabbay <ogabbay@...nel.org>, Takashi Sakamoto <o-takashi@...amocchi.jp>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	Alex Deucher <alexander.deucher@....com>, Christian König <christian.koenig@....com>, 
	Dave Airlie <airlied@...hat.com>, Jocelyn Falempe <jfalempe@...hat.com>, 
	Patrik Jakobsson <patrik.r.jakobsson@...il.com>, Xinliang Liu <xinliang.liu@...aro.org>, 
	Tian Tao <tiantao6@...ilicon.com>, Xinwei Kong <kong.kongxinwei@...ilicon.com>, 
	Sumit Semwal <sumit.semwal@...aro.org>, Yongqin Liu <yongqin.liu@...aro.org>, 
	John Stultz <jstultz@...gle.com>, Sui Jingfeng <suijingfeng@...ngson.cn>, 
	Lyude Paul <lyude@...hat.com>, Danilo Krummrich <dakr@...nel.org>, Gerd Hoffmann <kraxel@...hat.com>, 
	Zack Rusin <zack.rusin@...adcom.com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, 
	Lucas De Marchi <lucas.demarchi@...el.com>, 
	Thomas Hellström <thomas.hellstrom@...ux.intel.com>, 
	Rodrigo Vivi <rodrigo.vivi@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Saurav Kashyap <skashyap@...vell.com>, Javed Hasan <jhasan@...vell.com>, 
	GR-QLogic-Storage-Upstream@...vell.com, 
	"James E.J. Bottomley" <James.Bottomley@...senpartnership.com>, 
	"Martin K. Petersen" <martin.petersen@...cle.com>, Nilesh Javali <njavali@...vell.com>, 
	Manish Rangankar <mrangankar@...vell.com>, Alex Williamson <alex.williamson@...hat.com>, 
	Geert Uytterhoeven <geert+renesas@...der.be>, Javier Martinez Canillas <javierm@...hat.com>, 
	Jani Nikula <jani.nikula@...el.com>, Mario Limonciello <mario.limonciello@....com>, 
	Thomas Weißschuh <linux@...ssschuh.net>, 
	Lijo Lazar <lijo.lazar@....com>, Niklas Schnelle <schnelle@...ux.ibm.com>, 
	Dmitry Baryshkov <lumag@...nel.org>, linux-arm-msm@...r.kernel.org, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	linux1394-devel@...ts.sourceforge.net, amd-gfx@...ts.freedesktop.org, 
	nouveau@...ts.freedesktop.org, virtualization@...ts.linux.dev, 
	spice-devel@...ts.freedesktop.org, intel-xe@...ts.freedesktop.org, 
	netdev@...r.kernel.org, linux-pci@...r.kernel.org, linux-scsi@...r.kernel.org, 
	kvm@...r.kernel.org, Greg Ungerer <gerg@...ux-m68k.org>
Subject: Re: [RFC] PCI: add CONFIG_MMU dependency

Hi Arnd,

CC Gerg

On Mon, 7 Apr 2025 at 12:40, Arnd Bergmann <arnd@...nel.org> wrote:
> From: Arnd Bergmann <arnd@...db.de>
>
> It turns out that there are no platforms that have PCI but don't have an MMU,
> so adding a Kconfig dependency on CONFIG_PCI simplifies build testing kernels
> for those platforms a lot, and avoids a lot of inadvertent build regressions.
>
> Add a dependency for CONFIG_PCI and remove all the ones for PCI specific
> device drivers that are currently marked not having it.
>
> Link: https://lore.kernel.org/lkml/a41f1b20-a76c-43d8-8c36-f12744327a54@app.fastmail.com/
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks for your patch!

> --- a/drivers/pci/Kconfig
> +++ b/drivers/pci/Kconfig
> @@ -21,6 +21,7 @@ config GENERIC_PCI_IOMAP
>  menuconfig PCI
>         bool "PCI support"
>         depends on HAVE_PCI
> +       depends on MMU
>         help
>           This option enables support for the PCI local bus, including
>           support for PCI-X and the foundations for PCI Express support.

While having an MMU is a hardware feature, I consider disabling MMU
support software configuration.  So this change prevents people from
disabling MMU support on a system that has both a PCI bus and an MMU.
But other people may not agree, or care?

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds