linux-kernel - Re: [PATCH] firmware: arm_scmi: Balance device refcount when destroying devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <174410775216.2544674.4482099310313665654.b4-ty@arm.com>
Date: Tue,  8 Apr 2025 11:23:03 +0100
From: Sudeep Holla <sudeep.holla@....com>
To: linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	arm-scmi@...r.kernel.org,
	Cristian Marussi <cristian.marussi@....com>
Cc: Sudeep Holla <sudeep.holla@....com>,
	Alice Ryhl <aliceryhl@...gle.com>,
	Catalin Marinas <catalin.marinas@....com>
Subject: Re: [PATCH] firmware: arm_scmi: Balance device refcount when destroying devices

On Thu, 06 Mar 2025 18:54:47 +0000, Cristian Marussi wrote:
> Using device_find_child() to lookup the proper SCMI device to destroy
> causes an unbalance in device refcount, since device_find_child() calls an
> implicit get_device(): this, in turns, inhibits the call of the provided
> release methods upon devices destruction.
> 
> As a consequence, one of the structures that is not freed properly upon
> destruction is the internal struct device_private dev->p populated by the
> drivers subsystem core.
> 
> [...]

Applied to sudeep.holla/linux (for-next/scmi/fixes), thanks!

[1/1] firmware: arm_scmi: Balance device refcount when destroying devices
      https://git.kernel.org/sudeep.holla/c/9ca67840c0dd
--
Regards,
Sudeep