linux-kernel - Re: [PATCH v6 4/4] x86/sev: register tpm-svsm platform device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250408112820.GBZ_UIVPp-LuIiVrIV@fat_crate.local>
Date: Tue, 8 Apr 2025 13:28:20 +0200
From: Borislav Petkov <bp@...en8.de>
To: Stefano Garzarella <sgarzare@...hat.com>
Cc: Jarkko Sakkinen <jarkko@...nel.org>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	Peter Huewe <peterhuewe@....de>, Jason Gunthorpe <jgg@...pe.ca>,
	"H. Peter Anvin" <hpa@...or.com>, linux-coco@...ts.linux.dev,
	linux-integrity@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
	x86@...nel.org, Tom Lendacky <thomas.lendacky@....com>,
	Joerg Roedel <jroedel@...e.de>,
	Dionna Glaze <dionnaglaze@...gle.com>,
	Claudio Carvalho <cclaudio@...ux.ibm.com>,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	linux-kernel@...r.kernel.org, Dov Murik <dovmurik@...ux.ibm.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v6 4/4] x86/sev: register tpm-svsm platform device

On Tue, Apr 08, 2025 at 01:08:36PM +0200, Stefano Garzarella wrote:
> We discussed a bit on v3, but I'm open to change it:
> https://lore.kernel.org/linux-integrity/nrn4ur66lz2ocbkkjl2bgiex3xbp552szerfhalsaefunqxf7p@ki7xf66zrf6u/
> 
>  I tried to keep the logic of whether or not the driver is needed all in
> the tpm_svsm_probe()/snp_svsm_vtpm_probe() (where I check for SVSM).
>  If you prefer to move some pieces here, though, I'm open.

Yes please.

It doesn't make a whole lotta sense right now to register a TPM platform
driver at one place without even knowing you're running with an SVSM inside
the guest blob or not.

The usual approach is to register upon a successful detection.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette