linux-kernel - Re: [PATCH] ACPICA: exserial: don't forget to handle FFixedHW opregions for reading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0i_5mrCKBc+WMWviZa1r8x17rDX8DzCyMyQf=gwrTa0eg@mail.gmail.com>
Date: Wed, 9 Apr 2025 15:46:39 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Daniil Tatianin <d-tatianin@...dex-team.ru>
Cc: Robert Moore <robert.moore@...el.com>, 
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>, Len Brown <lenb@...nel.org>, 
	Sudeep Holla <sudeep.holla@....com>, linux-acpi@...r.kernel.org, 
	acpica-devel@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPICA: exserial: don't forget to handle FFixedHW
 opregions for reading

On Tue, Apr 1, 2025 at 8:46 PM Daniil Tatianin
<d-tatianin@...dex-team.ru> wrote:
>
> The initial commit that introduced support for FFixedHW operation
> regions did add a special case in the AcpiExReadSerialBus If, but
> forgot to actually handle it inside the switch, so add the missing case
> to prevent reads from failing with AE_AML_INVALID_SPACE_ID.
>
> Link: https://github.com/acpica/acpica/pull/998
> Fixes: ee64b827a9a ("ACPICA: Add support for FFH Opregion special context data")
> Signed-off-by: Daniil Tatianin <d-tatianin@...dex-team.ru>
> ---
>  drivers/acpi/acpica/exserial.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/acpi/acpica/exserial.c b/drivers/acpi/acpica/exserial.c
> index 5241f4c01c76..89a4ac447a2b 100644
> --- a/drivers/acpi/acpica/exserial.c
> +++ b/drivers/acpi/acpica/exserial.c
> @@ -201,6 +201,12 @@ acpi_ex_read_serial_bus(union acpi_operand_object *obj_desc,
>                 function = ACPI_READ;
>                 break;
>
> +       case ACPI_ADR_SPACE_FIXED_HARDWARE:
> +
> +               buffer_length = ACPI_FFH_INPUT_BUFFER_SIZE;
> +               function = ACPI_READ;
> +               break;
> +
>         default:
>                 return_ACPI_STATUS(AE_AML_INVALID_SPACE_ID);
>         }
> --

Applied as 6.16 material, thanks!