linux-kernel - Re: [PATCH v2] hwmon: (ina2xx) make regulator 'vs' support optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <badbf2eb-1968-4549-98eb-5ee916860090@roeck-us.net>
Date: Wed, 9 Apr 2025 07:32:50 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Ciprian Costea <ciprianmarian.costea@....nxp.com>
Cc: Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
	linux-kernel@...r.kernel.org, s32@....com, imx@...ts.linux.dev,
	Christophe Lizzi <clizzi@...hat.com>,
	Alberto Ruiz <aruizrui@...hat.com>,
	Enric Balletbo <eballetb@...hat.com>,
	Eric Chanudet <echanude@...hat.com>,
	Florin Buica <florin.buica@....com>
Subject: Re: [PATCH v2] hwmon: (ina2xx) make regulator 'vs' support optional

On Wed, Apr 09, 2025 at 10:45:29AM +0300, Ciprian Costea wrote:
> From: Ciprian Marian Costea <ciprianmarian.costea@....nxp.com>
> 
> According to the 'ti,ina2xx' binding, the 'vs-supply' property is
> optional. Use devm_regulator_get_enable_optional() to avoid a kernel
> warning message if the property is not provided.
> 
> Co-developed-by: Florin Buica <florin.buica@....com>
> Signed-off-by: Florin Buica <florin.buica@....com>
> Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@....nxp.com>

Applied, after converting multi-line comment to standard form.

Guenter

> ---
>  drivers/hwmon/ina2xx.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/ina2xx.c b/drivers/hwmon/ina2xx.c
> index 345fe7db9de9..b79e9c2072b3 100644
> --- a/drivers/hwmon/ina2xx.c
> +++ b/drivers/hwmon/ina2xx.c
> @@ -959,8 +959,11 @@ static int ina2xx_probe(struct i2c_client *client)
>  		return PTR_ERR(data->regmap);
>  	}
>  
> -	ret = devm_regulator_get_enable(dev, "vs");
> -	if (ret)
> +	/* Regulator core returns -ENODEV if the 'vs' is not available.
> +	 * Hence the check for -ENODEV return code is necessary.
> +	 */
> +	ret = devm_regulator_get_enable_optional(dev, "vs");
> +	if (ret < 0 && ret != -ENODEV)
>  		return dev_err_probe(dev, ret, "failed to enable vs regulator\n");
>  
>  	ret = ina2xx_init(dev, data);