linux-kernel - Re: [PATCH] HID: HID_APPLETB_BL and HID_APPLETB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PN0PR01MB95889912BB81D1B1B579C7FEB8B42@PN0PR01MB9588.INDPRD01.PROD.OUTLOOK.COM>
Date: Wed, 9 Apr 2025 20:05:33 +0530
From: Aditya Garg <gargaditya08@...e.com>
To: Geert Uytterhoeven <geert+renesas@...der.be>,
 Jiri Kosina <jikos@...nel.org>, Benjamin Tissoires <bentiss@...nel.org>,
 Kerem Karabay <kekrby@...il.com>
Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: HID_APPLETB_BL and HID_APPLETB_KBD should depend on
 X86



On 09-04-2025 02:51 pm, Geert Uytterhoeven wrote:
> The Apple Touch Bar is only present on x86 MacBook Pros.  Hence add a
> dependency on X86, to prevent asking the user about this driver when
> configuring a kernel for a different architecture.
> 
> Fixes: 1fd41e5e3d7cc556 ("HID: hid-appletb-bl: add driver for the backlight of Apple Touch Bars")
> Fixes: 93a0fc48948107e0 ("HID: hid-appletb-kbd: add support for automatic brightness control while using the touchbar")

Nit:

The commit SHA should have only the first 12 characters.

https://docs.kernel.org/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes

Also, hid-appletb-kbd fix should be:

Fixes: 8e9b9152cfbd ("HID: hid-appletb-kbd: add driver for the keyboard mode of Apple Touch Bars")

I would also prefer having them as 2 separate patches.
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>  drivers/hid/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index a503252702b7b43c..43859fc757470caf 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -151,6 +151,7 @@ config HID_APPLEIR
>  config HID_APPLETB_BL
>  	tristate "Apple Touch Bar Backlight"
>  	depends on BACKLIGHT_CLASS_DEVICE
> +	depends on X86 || COMPILE_TEST
>  	help
>  	  Say Y here if you want support for the backlight of Touch Bars on x86
>  	  MacBook Pros.
> @@ -163,6 +164,7 @@ config HID_APPLETB_KBD
>  	depends on USB_HID
>  	depends on BACKLIGHT_CLASS_DEVICE
>  	depends on INPUT
> +	depends on X86 || COMPILE_TEST
>  	select INPUT_SPARSEKMAP
>  	select HID_APPLETB_BL
>  	help