linux-kernel - Re: [PATCH net-next] net: batman-adv: constify and move broadcast addr definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3615fa6f-a837-4b4d-a987-52245710d84e@universe-factory.net>
Date: Wed, 9 Apr 2025 17:44:02 +0200
From: Matthias Schiffer <mschiffer@...verse-factory.net>
To: Sven Eckelmann <sven@...fation.org>,
 Marek Lindner <marek.lindner@...lbox.org>,
 Simon Wunderlich <sw@...onwunderlich.de>,
 Antonio Quartulli <antonio@...delbit.com>
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 b.a.t.m.a.n@...ts.open-mesh.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: batman-adv: constify and move broadcast
 addr definition

On 09/04/2025 10:10, Sven Eckelmann wrote:
> On Tuesday, 8 April 2025 17:53:36 CEST Matthias Schiffer wrote:
>> +       const u8 broadcast_addr[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
> 
> Should most likely be "static const u8 ..."
> 
> (checkpatch STATIC_CONST_CHAR_ARRAY)
> 
> Kind regards,
> 	Sven

Thanks, will send a v2. The checkpatch check only looks for strings, not 
arrays defined with { }, so it didn't trigger for me.

Best,
Matthias

Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (841 bytes)