linux-kernel - Re: [PATCH] iommu/vt-d: Remove an unnecessary call set_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250409174430.00ff4a09@meshulam.tesarici.cz>
Date: Wed, 9 Apr 2025 17:44:30 +0200
From: Petr Tesařík <petr@...arici.cz>
To: iommu@...ts.linux.dev
Cc: Petr Tesarik <ptesarik@...e.com>, David Woodhouse <dwmw2@...radead.org>,
 Lu Baolu <baolu.lu@...ux.intel.com>, Joerg Roedel <joro@...tes.org>, Will
 Deacon <will@...nel.org>, Robin Murphy <robin.murphy@....com>, Tom Murphy
 <murphyt7@....ie>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu/vt-d: Remove an unnecessary call set_dma_ops()

On Thu,  3 Apr 2025 18:56:05 +0200
Petr Tesarik <ptesarik@...e.com> wrote:

> Do not touch per-device DMA ops when the driver has been converted to use
> the dma-iommu API.
> 
> Fixes: c588072bba6b ("iommu/vt-d: Convert intel iommu driver to the iommu ops")
> Signed-off-by: Petr Tesarik <ptesarik@...e.com>

Does anyone agree? Or see any issues?

Petr T

> ---
>  drivers/iommu/intel/iommu.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> index bf1f0c814348..b7e500451d4f 100644
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -3789,7 +3789,6 @@ static void intel_iommu_release_device(struct device *dev)
>  	intel_pasid_free_table(dev);
>  	intel_iommu_debugfs_remove_dev(info);
>  	kfree(info);
> -	set_dma_ops(dev, NULL);
>  }
>  
>  static void intel_iommu_get_resv_regions(struct device *device,